Merge pull request #16984 from wordpress-mobile/analysis/detekt-fine-tune-default-rules

[Update Detekt Configuration] Fine-Tune Default Rules

Author: ParaskP7

WordPress/src/main/java/org/wordpress/android/AppInitializer.kt

@@ -124,7 +124,6 @@ import javax.inject.Inject
 import javax.inject.Named
 import javax.inject.Singleton
 
-@Suppress("TooManyFunctions")
 @Singleton
 class AppInitializer @Inject constructor(
     wellSqlInitializer: WellSqlInitializer,

WordPress/src/main/java/org/wordpress/android/WordPress.kt

@@ -28,7 +28,6 @@ abstract class WordPress : MultiDexApplication() {
         initializer().wordPressComSignOut()
     }
 
-    @Suppress("TooManyFunctions")
     companion object {
         const val SITE = "SITE"
         const val LOCAL_SITE_ID = "LOCAL_SITE_ID"

WordPress/src/main/java/org/wordpress/android/support/ZendeskHelper.kt

@@ -336,7 +336,6 @@ class ZendeskHelper(
 /**
  * This is a helper function which builds a `UiConfig` through helpers to be used during ticket creation.
  */
-@Suppress("LongParameterList")
 private fun buildZendeskConfig(
     context: Context,
     allSites: List<SiteModel>?,

WordPress/src/main/java/org/wordpress/android/ui/accounts/login/jetpack/LoginNoSitesFragment.kt

@@ -21,7 +21,6 @@ import org.wordpress.android.ui.main.utils.MeGravatarLoader
 import org.wordpress.android.ui.utils.UiHelpers
 import javax.inject.Inject
 
-@Suppress("TooManyFunctions")
 class LoginNoSitesFragment : Fragment(R.layout.jetpack_login_empty_view) {
     companion object {
         const val TAG = "LoginNoSitesFragment"

WordPress/src/main/java/org/wordpress/android/ui/accounts/login/jetpack/LoginSiteCheckErrorFragment.kt

@@ -19,7 +19,6 @@ import org.wordpress.android.ui.utils.HtmlMessageUtils
 import org.wordpress.android.util.ActivityUtils
 import javax.inject.Inject
 
-@Suppress("TooManyFunctions")
 class LoginSiteCheckErrorFragment : Fragment(R.layout.jetpack_login_empty_view) {
     companion object {
         const val TAG = "LoginSiteCheckErrorFragment"

WordPress/src/main/java/org/wordpress/android/ui/activitylog/detail/ActivityLogDetailFragment.kt

@@ -40,7 +40,6 @@ import javax.inject.Inject
 private const val DETAIL_TRACKING_SOURCE = "detail"
 private const val FORWARD_SLASH = "/"
 
-@Suppress("TooManyFunctions")
 @AndroidEntryPoint
 class ActivityLogDetailFragment : Fragment(R.layout.activity_log_item_detail) {
     @Inject lateinit var imageManager: ImageManager

WordPress/src/main/java/org/wordpress/android/ui/activitylog/list/filter/ActivityLogTypeFilterViewModel.kt

@@ -206,6 +206,7 @@ class ActivityLogTypeFilterViewModel @Inject constructor(
         ) : ListItemUiState()
     }
 
+    @Suppress("DataClassShouldBeImmutable")
     data class Action(val label: UiString) {
         lateinit var action: (() -> Unit)
     }

WordPress/src/main/java/org/wordpress/android/ui/bloggingreminders/BloggingRemindersAnalyticsTracker.kt

@@ -17,7 +17,6 @@ import org.wordpress.android.ui.bloggingreminders.BloggingRemindersViewModel.Scr
 import org.wordpress.android.util.analytics.AnalyticsTrackerWrapper
 import javax.inject.Inject
 
-@Suppress("TooManyFunctions")
 class BloggingRemindersAnalyticsTracker @Inject constructor(
     private val analyticsTracker: AnalyticsTrackerWrapper,
     private val siteStore: SiteStore

WordPress/src/main/java/org/wordpress/android/ui/bloggingreminders/BloggingRemindersViewModel.kt

@@ -33,7 +33,6 @@ import java.time.DayOfWeek
 import javax.inject.Inject
 import javax.inject.Named
 
-@Suppress("TooManyFunctions")
 class BloggingRemindersViewModel @Inject constructor(
     @Named(UI_THREAD) private val mainDispatcher: CoroutineDispatcher,
     private val bloggingRemindersManager: BloggingRemindersManager,

WordPress/src/main/java/org/wordpress/android/ui/comments/unified/UnifiedCommentListViewModel.kt

@@ -60,7 +60,6 @@ import javax.inject.Named
 
 typealias CommentsPagingResult = UseCaseResult<CommentsUseCaseType, CommentError, PagingData>
 
-@Suppress("TooManyFunctions")
 class UnifiedCommentListViewModel @Inject constructor(
     private val commentListUiModelHelper: CommentListUiModelHelper,
     private val selectedSiteRepository: SelectedSiteRepository,