Skip to content

Commit f82b87e

Browse files
authored
Merge pull request #17282 from wordpress-mobile/Jetpack-Focus-Show-or-hide-Automattic-Family-section-on-About-screen
Jetpack focus show or hide automattic family section on about screen
2 parents 2885159 + 33ddebf commit f82b87e

4 files changed

Lines changed: 37 additions & 4 deletions

File tree

RELEASE-NOTES.txt

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -2,6 +2,7 @@
22

33
21.0
44
-----
5+
* [***] Updated About screen for WordPress and Jetpack apps to their respective urls. [https://github.com/wordpress-mobile/WordPress-Android/pull/17282]
56
* [*] Updates splash screen for Android 12+ [https://github.com/wordpress-mobile/WordPress-Android/pull/17273]
67
* [*] Fix text color of success messages in the QR code login flow [https://github.com/wordpress-mobile/WordPress-Android/pull/17286]
78
* [*] Stats: Fix Western Arabic Numerals not being shown on every text of the stats screens in Arabic languages [https://github.com/wordpress-mobile/WordPress-Android/pull/17217]

WordPress/src/main/java/org/wordpress/android/ui/about/UnifiedAboutViewModel.kt

Lines changed: 33 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -4,13 +4,16 @@ import androidx.lifecycle.LiveData
44
import androidx.lifecycle.MutableLiveData
55
import androidx.lifecycle.ViewModel
66
import com.automattic.about.model.AboutConfig
7+
import com.automattic.about.model.AboutFooterConfig
78
import com.automattic.about.model.AnalyticsConfig
9+
import com.automattic.about.model.AutomatticConfig
810
import com.automattic.about.model.HeaderConfig
911
import com.automattic.about.model.ItemConfig
1012
import com.automattic.about.model.LegalConfig
1113
import com.automattic.about.model.RateUsConfig
1214
import com.automattic.about.model.ShareConfig
1315
import com.automattic.about.model.SocialsConfig
16+
import com.automattic.about.model.WorkWithUsConfig
1417
import org.wordpress.android.Constants
1518
import org.wordpress.android.R
1619
import org.wordpress.android.models.recommend.RecommendApiCallsProvider
@@ -49,7 +52,7 @@ class UnifiedAboutViewModel @Inject constructor(
4952
customItems = listOf(
5053
ItemConfig(
5154
name = BLOG_ITEM_NAME,
52-
title = contextProvider.getContext().getString(R.string.about_blog),
55+
title = blogTitle(),
5356
onClick = ::onBlogClick
5457
)
5558
),
@@ -58,6 +61,13 @@ class UnifiedAboutViewModel @Inject constructor(
5861
privacyPolicyUrl = Constants.URL_PRIVACY_POLICY,
5962
acknowledgementsUrl = LICENSES_FILE_URL
6063
),
64+
automatticConfig = AutomatticConfig(isVisible = buildConfig.isJetpackApp),
65+
workWithUsConfig = WorkWithUsConfig(
66+
title = workWithUsTitle(),
67+
subtitle = workWithUsSubTitle(),
68+
url = if (buildConfig.isJetpackApp) JP_WORK_WITH_US_URL else WP_CONTRIBUTE_URL
69+
),
70+
aboutFooterConfig = AboutFooterConfig(isVisible = buildConfig.isJetpackApp),
6171
analyticsConfig = AnalyticsConfig(
6272
trackScreenShown = unifiedAboutTracker::trackScreenShown,
6373
trackScreenDismissed = unifiedAboutTracker::trackScreenDismissed,
@@ -90,16 +100,36 @@ class UnifiedAboutViewModel @Inject constructor(
90100
_onNavigation.postValue(Event(OpenBlog(if (buildConfig.isJetpackApp) JP_BLOG_URL else WP_BLOG_URL)))
91101
}
92102

103+
private fun blogTitle() = if (buildConfig.isJetpackApp) {
104+
contextProvider.getContext().getString(R.string.about_blog)
105+
} else {
106+
contextProvider.getContext().getString(R.string.about_news)
107+
}
108+
109+
private fun workWithUsTitle() = if (buildConfig.isJetpackApp) {
110+
contextProvider.getContext().getString(R.string.about_automattic_work_with_us_item_title)
111+
} else {
112+
contextProvider.getContext().getString(R.string.about_automattic_contribute_item_title)
113+
}
114+
115+
private fun workWithUsSubTitle() = if (buildConfig.isJetpackApp) {
116+
contextProvider.getContext().getString(R.string.about_automattic_work_with_us_item_subtitle)
117+
} else {
118+
null
119+
}
120+
93121
companion object {
94122
private const val BLOG_ITEM_NAME = "blog"
95123
private const val LICENSES_FILE_URL = "file:///android_asset/licenses.html"
96124

97-
private const val WP_SOCIAL_HANDLE = "wordpress"
125+
private const val WP_SOCIAL_HANDLE = "WPAndroid"
98126
private const val WP_APPS_URL = "https://apps.wordpress.com"
99-
private const val WP_BLOG_URL = "https://blog.wordpress.com"
127+
private const val WP_BLOG_URL = "https://wordpress.org/news/"
128+
private const val WP_CONTRIBUTE_URL = "https://make.wordpress.org/mobile/handbook/"
100129

101130
private const val JP_SOCIAL_HANDLE = "jetpack"
102131
private const val JP_APPS_URL = "https://jetpack.com/app"
103132
private const val JP_BLOG_URL = "https://jetpack.com/blog"
133+
private const val JP_WORK_WITH_US_URL = "https://automattic.com/work-with-us/"
104134
}
105135
}

WordPress/src/main/res/values/strings.xml

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -4057,6 +4057,7 @@ translators: %s: Select control option value e.g: "Auto, 25%". -->
40574057

40584058
<!-- About -->
40594059
<string name="about_blog">Blog</string>
4060+
<string name="about_news">News</string>
40604061
<string name="about_automattic_main_page_title" tools:ignore="UnusedResources" a8c-src-lib="about">About %1$s</string>
40614062
<string name="about_automattic_legal_page_title" tools:ignore="UnusedResources" a8c-src-lib="about">Legal and More</string>
40624063
<string name="about_automattic_acknowledgements_page_title" tools:ignore="UnusedResources" a8c-src-lib="about">Acknowledgements</string>
@@ -4068,6 +4069,7 @@ translators: %s: Select control option value e.g: "Auto, 25%". -->
40684069
<string name="about_automattic_legal_and_more_item_title" tools:ignore="UnusedResources" a8c-src-lib="about">Legal and More</string>
40694070
<string name="about_automattic_family_item_title" tools:ignore="UnusedResources" a8c-src-lib="about">Automattic Family</string>
40704071
<string name="about_automattic_work_with_us_item_title" tools:ignore="UnusedResources" a8c-src-lib="about">Work With Us</string>
4072+
<string name="about_automattic_contribute_item_title" tools:ignore="UnusedResources" a8c-src-lib="about">Contribute</string>
40714073
<string name="about_automattic_work_with_us_item_subtitle" tools:ignore="UnusedResources" a8c-src-lib="about">Work from Anywhere</string>
40724074
<string name="about_automattic_terms_of_service_item_title" tools:ignore="UnusedResources" a8c-src-lib="about">Terms of Service</string>
40734075
<string name="about_automattic_privacy_policy_item_title" tools:ignore="UnusedResources" a8c-src-lib="about">Privacy Policy</string>

build.gradle

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -15,7 +15,7 @@ ext {
1515
aztecVersion = 'v1.6.0'
1616
gutenbergMobileVersion = 'v1.83.0'
1717
storiesVersion = '1.4.0'
18-
aboutAutomatticVersion = '0.0.6'
18+
aboutAutomatticVersion = '0.0.7'
1919

2020
minSdkVersion = 24
2121
compileSdkVersion = 31

0 commit comments

Comments
 (0)