Apply PR suggestion: add reminders synced count to track success analytics event on BloggingRemindersResolver

Author: RenanLukas

WordPress/src/main/java/org/wordpress/android/bloggingreminders/resolver/BloggingRemindersResolver.kt

@@ -56,7 +56,7 @@ class BloggingRemindersResolver @Inject constructor(
                 if (success) onSuccess() else onFailure()
             } else {
                 bloggingRemindersSyncAnalyticsTracker.trackSuccess(0)
-                onFailure()
+                onSuccess()
             }
         } else {
             bloggingRemindersSyncAnalyticsTracker.trackFailed(ErrorType.QueryBloggingRemindersError)
@@ -77,6 +77,7 @@ class BloggingRemindersResolver @Inject constructor(
     private fun syncBloggingReminders(siteIdBloggingReminderMap: SiteIDBloggingReminderMap): Boolean {
         try {
             coroutineScope.launch {
+                var remindersSyncedCount = 0
                 for ((siteId, bloggingReminder) in siteIdBloggingReminderMap) {
                     if (siteId == null || bloggingReminder == null) {
                         continue
@@ -85,7 +86,7 @@ class BloggingRemindersResolver @Inject constructor(
                     val isBloggingReminderAlreadySet = bloggingRemindersStore.bloggingRemindersModel(siteLocalId)
                             .first().enabledDays.isNotEmpty()
                     if (siteLocalId != 0 && !isBloggingReminderAlreadySet) {
-                        remindersSyncedCount = ++remindersSyncedCount
+                        remindersSyncedCount = remindersSyncedCount.inc()
                         bloggingRemindersStore.updateBloggingReminders(bloggingReminder.copy(siteId = siteLocalId))
                     }
                 }

WordPress/src/test/java/org/wordpress/android/bloggingreminders/BloggingRemindersSyncAnalyticsTrackerTest.kt

@@ -19,16 +19,10 @@ class BloggingRemindersSyncAnalyticsTrackerTest {
 
     @Test
     fun `Should track get blogging reminders success correctly`() {
-        classToTest.trackSuccess()
-        verify(analyticsTrackerWrapper).track(Stat.BLOGGING_REMINDERS_SYNC_SUCCESS)
-    }
-
-    @Test
-    fun `Should track failed with NoBloggingRemindersFoundError correctly`() {
-        classToTest.trackFailed(ErrorType.NoBloggingRemindersFoundError)
+        val remindersSyncedCount = 3
+        classToTest.trackSuccess(remindersSyncedCount)
         verify(analyticsTrackerWrapper).track(
-                Stat.BLOGGING_REMINDERS_SYNC_FAILED,
-                mapOf("error_type" to "no_blogging_reminders_found_error")
+                Stat.BLOGGING_REMINDERS_SYNC_SUCCESS, mapOf(REMINDERS_SYNCED_COUNT to remindersSyncedCount)
         )
     }
 

WordPress/src/test/java/org/wordpress/android/bloggingreminders/resolver/BloggingRemindersResolverTest.kt

@@ -16,7 +16,6 @@ import org.junit.Rule
 import org.junit.Test
 import org.wordpress.android.MainCoroutineScopeRule
 import org.wordpress.android.bloggingreminders.BloggingRemindersSyncAnalyticsTracker
-import org.wordpress.android.bloggingreminders.BloggingRemindersSyncAnalyticsTracker.ErrorType.NoBloggingRemindersFoundError
 import org.wordpress.android.bloggingreminders.BloggingRemindersSyncAnalyticsTracker.ErrorType.QueryBloggingRemindersError
 import org.wordpress.android.bloggingreminders.JetpackBloggingRemindersSyncFlag
 import org.wordpress.android.bloggingreminders.provider.BloggingRemindersProvider
@@ -149,10 +148,10 @@ class BloggingRemindersResolverTest {
     }
 
     @Test
-    fun `Should track failed with error NoBloggingRemindersFoundError if result map is empty`() {
+    fun `Should track success with reminders synced count 0 if result map is empty`() {
         featureEnabled()
         classToTest.trySyncBloggingReminders({}, {})
-        verify(bloggingRemindersSyncAnalyticsTracker).trackFailed(NoBloggingRemindersFoundError)
+        verify(bloggingRemindersSyncAnalyticsTracker).trackSuccess(0)
     }
 
     @Test
@@ -165,14 +164,14 @@ class BloggingRemindersResolverTest {
 
     @Test
     fun `Should track success if result map has entries`() = test {
-        whenever(bloggingRemindersStore.bloggingRemindersModel(validLocalId))
-                .thenReturn(flowOf(userSetBloggingRemindersModel))
         whenever(siteStore.getLocalIdForRemoteSiteId(123L)).thenReturn(validLocalId)
+        whenever(bloggingRemindersStore.bloggingRemindersModel(validLocalId))
+                .thenReturn(flowOf(defaultBloggingRemindersModel))
         featureEnabled()
         whenever(mockCursor.getString(0)).thenReturn("{\"123\":{\"enabledDays\":[\"MONDAY\"],\"hour\":5" +
                 ",\"isPromptIncluded\":false,\"minute\":43,\"siteId\":123}}")
         classToTest.trySyncBloggingReminders({}, {})
-        verify(bloggingRemindersSyncAnalyticsTracker).trackSuccess()
+        verify(bloggingRemindersSyncAnalyticsTracker).trackSuccess(1)
     }
 
     @Test