NonConstantResouceID results in build errors

[07jasjeet]

Problem

So, the codebase has multiple instances where Resource IDs are directly used in places where only final objects can be used. This introduces compile-time errors as Resource IDs are not final anymore in newer versions. (Ref) These instances are:

1. const vals (constant values) are being assigned with Resource IDs.
2. Also using Resource IDs in switch case statements results in the same.

Proposed Solution

1. Remove const and annotate the field with @JvmField which results in generated bytecode being similar to latter. (Cross-Verified Ref).
2. Replace switch with if-else where resource IDs are used. (Ref)

This proposed solution works on my machine AS Giraffe 2022.3.1 Patch 1 and would gladly open a PR if required.

[peril-wordpress-mobile]

	Fails
🚫	Please add a type label to this issue. e.g. '[Type] Enhancement'
🚫	Please add a feature label to this issue. e.g. 'Stats'

Generated by 🚫 dangerJS

[dangermattic]

Thanks for reporting! 👍

[jkmassel]

This issue appears to be no longer applicable. A review of the current codebase shows:

• No const val declarations with R.* values — the main pattern this issue described has been resolved.
• Only one switch statement with a resource ID — in AppSettingsFragment.java, using android.R.id.home, which is a framework constant and is valid.
• All Kotlin when expressions using R.* values are correct (Kotlin doesn't require compile-time constants for when).

Closing as resolved.