Skip to content

Update dependency fastlane-plugin-wpmreleasetoolkit to v11 - #20922

Merged
iangmaia merged 4 commits into
trunkfrom
renovate/fastlane-plugin-wpmreleasetoolkit-11.x
Jun 17, 2024
Merged

Update dependency fastlane-plugin-wpmreleasetoolkit to v11#20922
iangmaia merged 4 commits into
trunkfrom
renovate/fastlane-plugin-wpmreleasetoolkit-11.x

Conversation

@renovate

@renovate renovate Bot commented May 31, 2024

Copy link
Copy Markdown
Contributor

Mend Renovate

This PR contains the following updates:

Package Change Age Adoption Passing Confidence
fastlane-plugin-wpmreleasetoolkit '~> 9.2' -> '~> 11.0' age adoption passing confidence

Release Notes

wordpress-mobile/release-toolkit (fastlane-plugin-wpmreleasetoolkit)

v11.0.1

Compare Source

Bug Fixes
  • Fixed the android_download_translations action by correctly calling Fastlane's git_submodule_update action [#​561]

v11.0.0

Compare Source

Breaking Changes
  • Make ios_check_beta_deps use the Podfile.lock instead of Podfile for its detection, and also be able to detect Pods referenced by commits and branches.
    If your Fastfile called this action with an explicit podfile: … argument, you'll have to update the call to use lockfile: instead (or rely on defaults). [#​557]

v10.0.0

Compare Source

Breaking Changes
  • Upgraded the minimum required Ruby version to 3.2.2. [#​517]
  • Removed the old setbranchprotection and removebranchprotection backwards-compatiblity stubs for the now-renamed set_branch_protection and remove_branch_protection actions. [#​549]
  • Renamed setfrozentag action to set_milestone_frozen_marker. [#​548]
  • Removed the ios_clear_intermediate_tags action, which has been deprecated for a while. [#​549]
  • Removed the has_alpha_version option from several actions and helper methods. It has already been deprecated for many versions. [#​550]
  • Removed the project_name and project_root_folder options from several actions. [#​550]
  • Renamed update_pull_requests_milestone to update_assigned_milestone and make it handle GitHub issues as well as PRs. [#​547]
Bug Fixes
  • Fixed comment_on_pr to allow first paragraph of the comment to still be interpreted as Markdown. [#​544]
Internal Changes
  • Added a deprecation notice to the GitHelper.ensure_on_branch! method [#​531]
  • Added a deprecation notice to the GitHelper.update_submodules method [#​531]
  • Update nokogiri, mini_portile2, and rmagick [#​546]

Configuration

📅 Schedule: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined).

🚦 Automerge: Disabled by config. Please merge this manually once you are satisfied.

♻ Rebasing: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox.

🔕 Ignore: Close this PR and you won't be reminded about this update again.

  • If you want to rebase/retry this PR, check this box

This PR has been generated by Mend Renovate. View repository job log here.

@dangermattic

dangermattic commented May 31, 2024 •
edited
Loading

Copy link
Copy Markdown
Collaborator
1 Warning
⚠️ PR is not assigned to a milestone.

Generated by 🚫 Danger

@wpmobilebot

wpmobilebot commented May 31, 2024 •
edited
Loading

Copy link
Copy Markdown
Contributor
WordPress📲 You can test the changes from this Pull Request in WordPress by scanning the QR code below to install the corresponding build.
App NameWordPress WordPress
FlavorJalapeno
Build TypeDebug
Versionpr20922-a378a5e
Commita378a5e
Direct Downloadwordpress-prototype-build-pr20922-a378a5e.apk
 Note: Google Login is not supported on these builds.

@wpmobilebot

wpmobilebot commented May 31, 2024 •
edited
Loading

Copy link
Copy Markdown
Contributor
Jetpack📲 You can test the changes from this Pull Request in Jetpack by scanning the QR code below to install the corresponding build.
App NameJetpack Jetpack
FlavorJalapeno
Build TypeDebug
Versionpr20922-a378a5e
Commita378a5e
Direct Downloadjetpack-prototype-build-pr20922-a378a5e.apk
 Note: Google Login is not supported on these builds.

@wzieba

wzieba commented Jun 4, 2024

Copy link
Copy Markdown
Contributor

@iangmaia @AliSoftware - is it safe to merge? I'd like to double-check with you, as this is a bump of 2 major.

AliSoftware
AliSoftware requested changes Jun 4, 2024
View reviewed changes

@AliSoftware AliSoftware left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This major bump can't be merged without changes to the fastlane files (see inline comment + migration guide)

Comment thread Gemfile

gem 'fastlane-plugin-sentry'
gem 'fastlane-plugin-wpmreleasetoolkit', '~> 9.2'
gem 'fastlane-plugin-wpmreleasetoolkit', '~> 11.0'

@AliSoftware AliSoftware Jun 4, 2024 •
edited by iangmaia
Loading

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

See https://github.com/wordpress-mobile/release-toolkit/blob/trunk/MIGRATION.md

  • Project uses ruby version 3.2.2 ➡️ yes
  • setbranchprotection renamed to set_branch_protection, with copy_branch_protection(from:…) being usually even a better replacement for it ➡️ ❌ Used in fastlane/lanes/release.rb:79
  • removebranchprotection renamed remove_branch_protection ➡️ ❌ Used in fastlane/lanes/release.rb:296
  • setfrozentag renamed set_milestone_frozen_marker ➡️ ❌ Used in fastlane/lanes/release.rb:80 and in fastlane/lanes/release.rb:318
  • ios_clear_intermediate_tags and ios_final_tag actions removed: Not applicable for Android projects
  • has_alpha_version removed ➡️ ✅ Not used
  • project_name and project_root_folder removed ➡️ ✅ Not used
  • update_pull_requests_milestone renamed to update_assigned_milestone (+ parameters renamed) ➡️ ✅ Not used
  • ios_check_beta_deps parameter updated: N/A to Android projects

@iangmaia iangmaia Jun 14, 2024

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've updated the calls to be in line with the release-toolkit version 11.0.2 (cc @wzieba)

@iangmaia
iangmaia force-pushed the renovate/fastlane-plugin-wpmreleasetoolkit-11.x branch from 479189c to d20a7bf Compare June 14, 2024 10:14
@iangmaia
iangmaia enabled auto-merge June 14, 2024 10:38
AliSoftware
AliSoftware reviewed Jun 14, 2024
View reviewed changes
Comment thread fastlane/lanes/release.rb Outdated

setbranchprotection(repository: GHHELPER_REPO, branch: "release/#{new_version}")
setfrozentag(repository: GHHELPER_REPO, milestone: new_version)
set_branch_protection(repository: GHHELPER_REPO, branch: "release/#{new_version}")

@AliSoftware AliSoftware Jun 14, 2024

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Shouldn't we start using copy_branch_protection(from: DEFAULT_BRANCH, to: "release/…") instead?

@iangmaia iangmaia Jun 17, 2024

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

At first I thought it would be ok to keep as set, but I realize now apps seem to use copy_branch_protection; also, it will just follow whatever we have in trunk, which might be different per repo so it seems more consistent. Changed on a378a5e.

@wzieba
wzieba requested a review from iangmaia June 17, 2024 11:57
@sonarqubecloud

sonarqubecloud Bot commented Jun 17, 2024

Copy link
Copy Markdown

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
No data about Duplication

See analysis details on SonarCloud

@iangmaia
iangmaia requested a review from AliSoftware June 17, 2024 15:57
@iangmaia
iangmaia merged commit 3f30c51 into trunk Jun 17, 2024
@iangmaia
iangmaia deleted the renovate/fastlane-plugin-wpmreleasetoolkit-11.x branch June 17, 2024 16:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@AliSoftware AliSoftware AliSoftware approved these changes
@iangmaia iangmaia Awaiting requested review from iangmaia

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@dangermattic @wpmobilebot @wzieba @AliSoftware @iangmaia