Skip to content

Add regression test for null-username application password creation #22998

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
adalpari wants to merge 1 commit into from
Closed

Add regression test for null-username application password creation #22998

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
16 changes: 16 additions & 0 deletions .../android/fluxc/network/rest/wpapi/applicationpasswords/ApplicationPasswordManagerTests.kt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -89,6 +89,22 @@ class ApplicationPasswordManagerTests {
verify(applicationPasswordsStore).saveCredentials(site, testCredentials)
}

@Test
fun `given a non-jetpack site with a null username, when we ask for a password, then return Failure`() =
runTest {
val site = SiteModel().apply {
url = "http://no-username.example.com"
origin = SiteModel.ORIGIN_XMLRPC
username = null
}

whenever(applicationPasswordsStore.getCredentials(site)).thenReturn(null)

val result = mApplicationPasswordsManager.getApplicationCredentials(site)

Assert.assertTrue(result is ApplicationPasswordCreationResult.Failure)
}

@Test
fun `given a local password exists, when we ask for a password, then return it`() = runTest {
whenever(applicationPasswordsStore.getCredentials(testSite)).thenReturn(testCredentials)
Expand Down
Loading