Skip to content

fix: read EXIF orientation directly for plain file paths #156

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
dcalhoun wants to merge 1 commit into
base: trunk
Choose a base branch
from
Draft

fix: read EXIF orientation directly for plain file paths #156

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 8 additions & 0 deletions WordPressUtils/src/main/java/org/wordpress/android/util/ImageUtils.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -90,6 +90,14 @@ public static int getImageOrientation(Context ctx, String filePath) {
filePath = filePath.replace("file://", "");

if (!filePath.contains("content://")) {
// A plain filesystem path pointing at an existing file (e.g. an app cache file) is not
// resolvable through the MediaStore content provider — prefixing it with
// "content://media" would produce a bogus Uri whose query always fails (throwing on
// some devices). EXIF is the only orientation source such a file has, so read it
// directly.
if (new File(filePath).exists()) {
return getExifOrientation(filePath);
}
curStream = Uri.parse("content://media" + filePath);
} else {
curStream = Uri.parse(filePath);
Expand Down
Loading