Tweaks to prevent unnecessary checks running while a PR is a Draft

Author: iangmaia

.github/workflows/run-danger.yml

@@ -2,10 +2,12 @@ name: ☢️ Danger
 
 on:
   pull_request:
-    types: [opened, synchronize, edited, review_requested, review_request_removed, labeled, unlabeled, milestoned, demilestoned]
+    types: [opened, reopened, ready_for_review, synchronize, edited, labeled, unlabeled, milestoned, demilestoned]
 
 jobs:
   dangermattic:
+    # runs on draft PRs only for opened / synchronize events
+    if: ${{ (github.event.pull_request.draft == false) || (github.event.pull_request.draft == true && contains(fromJSON('["opened", "synchronize"]'), github.event.action)) }}
     uses: Automattic/dangermattic/.github/workflows/reusable-run-danger.yml@v1.0.0
     secrets:
       github-token: ${{ secrets.DANGERMATTIC_GITHUB_TOKEN }}

Dangerfile

@@ -22,17 +22,18 @@ common_release_checker.check_internal_release_notes_changed(report_type: :messag
 
 ios_release_checker.check_modified_translations_on_release_branch
 
+view_changes_checker.check
+
+pr_size_checker.check_diff_size(max_size: 500)
+
+# skip remaining checks if we have a Draft PR
+return if github.pr_draft?
+
 labels_checker.check(
   do_not_merge_labels: ['[Status] DO NOT MERGE'],
   required_labels: [//],
   required_labels_error: 'PR requires at least one label.'
 )
 
-view_changes_checker.check
-
-pr_size_checker.check_diff_size(max_size: 500)
-
-# skip check for draft PRs and for WIP features unless the PR is against the main branch or release branch
-unless github.pr_draft? || (github_utils.wip_feature? && !(github_utils.release_branch? || github_utils.main_branch?))
-  milestone_checker.check_milestone_due_date(days_before_due: 4)
-end
+# skip check for WIP features unless the PR is against the main branch or release branch
+milestone_checker.check_milestone_due_date(days_before_due: 4) unless github_utils.wip_feature? && !(github_utils.release_branch? || github_utils.main_branch?)