Merge pull request #17863 from wordpress-mobile/task/msd-remove-blog-details-table-header-view

My Site Dashboard: Remove table header view from BlogDetailsViewController

Author: momo-ozawa

WordPress/Classes/Extensions/UIScrollView+Helpers.swift

@@ -21,7 +21,7 @@ extension UIScrollView {
                                         height: safeAreaLayoutGuide.layoutFrame.height)
                 scrollRectToVisible(targetRect, animated: animated)
             } else {
-                scrollToBottom()
+                scrollToBottom(animated: true)
             }
 
             // This ensures scrolling to the correct position, especially when there are layout changes
@@ -32,10 +32,15 @@ extension UIScrollView {
         }
     }
 
-    @objc func scrollToBottom() {
+    @objc func scrollToTop(animated: Bool) {
+        let topOffset = CGPoint(x: 0, y: -adjustedContentInset.top)
+        setContentOffset(topOffset, animated: animated)
+    }
+
+    @objc func scrollToBottom(animated: Bool) {
         let bottomOffset = CGPoint(x: 0, y: contentSize.height - bounds.size.height + adjustedContentInset.bottom)
         if bottomOffset.y > 0 {
-            setContentOffset(bottomOffset, animated: true)
+            setContentOffset(bottomOffset, animated: animated)
         }
     }
 

WordPress/Classes/ViewRelated/Blog/Blog Details/BlogDetailsViewController+FancyAlerts.swift

@@ -12,21 +12,18 @@ extension BlogDetailsViewController {
             guard self?.blog.managedObjectContext != nil else {
                 return
             }
-            self?.toggleSpotlightForSiteTitle()
-            self?.refreshSiteIcon()
             self?.configureTableViewData()
             self?.reloadTableViewPreservingSelection()
 
             if let info = notification.userInfo?[QuickStartTourGuide.notificationElementKey] as? QuickStartTourElement {
                 switch info {
                 case .noSuchElement:
-                    if FeatureFlag.mySiteDashboard.enabled,
-                       let parentVC = self?.parent as? MySiteViewController {
-                        parentVC.additionalSafeAreaInsets = .zero
-                    } else {
-                        self?.additionalSafeAreaInsets = .zero
+                    guard let parentVC = self?.parent as? MySiteViewController else {
+                        return
                     }
 
+                    parentVC.additionalSafeAreaInsets = .zero
+
                 case .siteIcon, .siteTitle:
                     // handles the padding in case the element is not in the table view
                     self?.additionalSafeAreaInsets = UIEdgeInsets(top: 0, left: 0, bottom: BlogDetailsViewController.bottomPaddingForQuickStartNotices, right: 0)
@@ -115,9 +112,7 @@ extension BlogDetailsViewController {
     private func showQuickStart(with type: QuickStartType) {
         let checklist = QuickStartChecklistViewController(blog: blog, type: type)
         let navigationViewController = UINavigationController(rootViewController: checklist)
-        present(navigationViewController, animated: true) { [weak self] in
-            self?.toggleSpotlightOnHeaderView()
-        }
+        present(navigationViewController, animated: true)
 
         QuickStartTourGuide.shared.visited(.checklist)