Custom Posts: Show "Post updated" notice (#25576)

crazytonyli · web-flow · commit 18dd66a886f8 · 2026-06-28T23:59:30.000Z
* Show success notice when a custom post is saved to the site

Post a Notice toast on every HTTP write to the site from the Custom Post editor (save draft, update, publish) and from the standalone settings sheet reached from the Custom Posts list. The notice's title reflects the action: "Draft saved" only on the first save of a brand-new post, "Post updated" for any save of an existing post, and "Post published" via the publishing sheet. The post title is the notice's subtitle (omitted when empty). Localized strings live in a shared CustomPostNotice enum.

* Reformat PublishPostViewController with swift-format

* Show the published notice for both custom post publishing flows

Move the success notice into PublishPostViewController.show(editorService:blog:from:completion:) so both the custom post editor and the Custom Posts list show it after publishing through the sheet. Consolidate the duplicated notice strings into a shared CustomPostNoticeStrings type.

* Remove the unused publish argument from CustomPostEditorViewController.save

The method is only ever called to persist a draft or update, so drop the always-false publish parameter and the dead publish-only branches.
diff --git a/WordPress/Classes/ViewRelated/CustomPostTypes/CustomPostListViewModel.swift b/WordPress/Classes/ViewRelated/CustomPostTypes/CustomPostListViewModel.swift
@@ -417,6 +417,11 @@ final class CustomPostListViewModel: ObservableObject {
                 wpService: service
             )
             let viewModel = CustomPostSettingsViewModel(editorService: editorService, blog: blog, isStandalone: true)
+            viewModel.onEditorPostSaved = { [editorService] in
+                let postTitle = editorService.post?.title?.raw
+                let subtitle = (postTitle?.isEmpty == false) ? postTitle : nil
+                Notice(title: CustomPostNoticeStrings.postUpdated, message: subtitle, feedbackType: .success).post()
+            }
             let settingsVC = PostSettingsViewController(viewModel: viewModel)
             let nav = UINavigationController(rootViewController: settingsVC)
             vc.present(nav, animated: true)
diff --git a/WordPress/Classes/ViewRelated/CustomPostTypes/CustomPostNoticeStrings.swift b/WordPress/Classes/ViewRelated/CustomPostTypes/CustomPostNoticeStrings.swift
@@ -0,0 +1,22 @@
+import Foundation
+
+/// Localized titles for the success notices emitted when a custom post is
+/// persisted to the server. Shared between the editor, the publishing sheet,
+/// and the Custom Posts list.
+enum CustomPostNoticeStrings {
+    static let draftSaved = NSLocalizedString(
+        "customPost.notice.draftSaved",
+        value: "Draft saved",
+        comment: "Success notice shown after a new draft custom post is created on the server."
+    )
+    static let postUpdated = NSLocalizedString(
+        "customPost.notice.postUpdated",
+        value: "Post updated",
+        comment: "Success notice shown after an existing custom post is updated on the server."
+    )
+    static let postPublished = NSLocalizedString(
+        "customPost.notice.postPublished",
+        value: "Post published",
+        comment: "Success notice shown after a custom post is published on the server."
+    )
+}
diff --git a/WordPress/Classes/ViewRelated/NewGutenberg/CustomPostEditorViewController.swift b/WordPress/Classes/ViewRelated/NewGutenberg/CustomPostEditorViewController.swift
@@ -143,7 +143,7 @@ private extension CustomPostEditorViewController {
                         style: .default,
                         handler: { [weak self] _ in
                             Task {
-                                await self?.save(publish: false)
+                                await self?.save()
                             }
                         }
                     )
@@ -170,7 +170,7 @@ private extension CustomPostEditorViewController {
                         attributes: enabled ? [] : [.disabled]
                     ) { [weak self] _ in
                         Task {
-                            await self?.save(publish: false)
+                            await self?.save()
                         }
                     }
                     resolve([saveDraft])
@@ -197,7 +197,7 @@ private extension CustomPostEditorViewController {
         } else {
             return UIAction(title: PostEditorStrings.update) { [weak self] _ in
                 Task {
-                    await self?.save(publish: false)
+                    await self?.save()
                 }
             }
         }
@@ -228,12 +228,8 @@ private extension CustomPostEditorViewController {
             blog: blog,
             from: self,
             completion: { [weak self] result in
-                guard let self else { return }
-                switch result {
-                case .published:
-                    completion()
-                case .cancelled:
-                    break
+                if case .published = result {
+                    self?.completion()
                 }
             }
         )
@@ -248,21 +244,27 @@ private extension CustomPostEditorViewController {
 
 private extension CustomPostEditorViewController {
 
-    func save(publish: Bool) async {
+    func save() async {
         SVProgressHUD.show()
 
+        // Capture whether this is a brand-new post (not yet on the server) so the
+        // notice can distinguish "Draft saved" (just created) from "Post updated"
+        // (edited an existing post). Any save of an already-existing post (draft
+        // or published) reads as an update from the user's perspective.
+        let isNewPost = post == nil
+
         do {
             let data = try await editorViewController.getTitleAndContent()
             try await editorService.save(
                 content: EditorContent(title: data.title, content: data.content),
-                publish: publish
+                publish: false
             )
 
             dismissHUDWithSuccess()
 
-            if publish {
-                completion()
-            }
+            let title = isNewPost ? CustomPostNoticeStrings.draftSaved : CustomPostNoticeStrings.postUpdated
+            let subtitle = data.title.isEmpty ? nil : data.title
+            Notice(title: title, message: subtitle, feedbackType: .success).post()
         } catch {
             SVProgressHUD.showError(withStatus: error.localizedDescription)
         }
diff --git a/WordPress/Classes/ViewRelated/Post/Publishing/PublishPostViewController.swift b/WordPress/Classes/ViewRelated/Post/Publishing/PublishPostViewController.swift
@@ -81,7 +81,14 @@ final class PublishPostViewController<ViewModel: PostSettingsViewModelProtocol>:
             editorService: editorService,
             blog: blog
         )
-        publishVC.onCompletion = completion
+        publishVC.onCompletion = { result in
+            if case .published = result {
+                let postTitle = editorService.post?.title?.raw
+                let subtitle = (postTitle?.isEmpty == false) ? postTitle : nil
+                Notice(title: CustomPostNoticeStrings.postPublished, message: subtitle, feedbackType: .success).post()
+            }
+            completion(result)
+        }
         let navigationVC = UINavigationController(rootViewController: publishVC)
         navigationVC.sheetPresentationController?.detents = [
             .custom(identifier: .medium, resolver: { _ in 526 }),
@@ -221,23 +228,82 @@ private typealias Strings = PrepublishingSheetStrings
 
 enum PrepublishingSheetStrings {
     static let title = NSLocalizedString("prepublishing.title", value: "Publishing", comment: "Navigation title")
-    static let publishingTo = NSLocalizedString("prepublishing.publishingTo", value: "Publishing to", comment: "Label in the header in the pre-publishing sheet")
-    static let publish = NSLocalizedString("prepublishing.publish", value: "Publish", comment: "Primary button label in the pre-publishing sheet")
-    static let schedule = NSLocalizedString("prepublishing.schedule", value: "Schedule", comment: "Primary button label in the pre-publishing shee")
-    static let publishDate = NSLocalizedString("prepublishing.publishDate", value: "Publish Date", comment: "Label for a cell in the pre-publishing sheet")
-    static let visibility = NSLocalizedString("prepublishing.visibility", value: "Visibility", comment: "Label for a cell in the pre-publishing sheet")
-    static let categories = NSLocalizedString("prepublishing.categories", value: "Categories", comment: "Label for a cell in the pre-publishing sheet")
-    static let tags = NSLocalizedString("prepublishing.tags", value: "Tags", comment: "Label for a cell in the pre-publishing sheet")
-    static let jetpackSocial = NSLocalizedString("prepublishing.jetpackSocial", value: "Jetpack Social", comment: "Label for a cell in the pre-publishing sheet")
-    static let immediately = NSLocalizedString("prepublishing.publishDateImmediately", value: "Immediately", comment: "Placeholder value for a publishing date in the prepublishing sheet when the date is not selected")
-    static let uploadingMedia = NSLocalizedString("prepublishing.uploadingMedia", value: "Uploading media", comment: "Title for a publish button state in the pre-publishing sheet")
-    private static let uploadMediaOneItemRemaining = NSLocalizedString("prepublishing.uploadMediaOneItemRemaining", value: "%@ item remaining", comment: "Details label for a publish button state in the pre-publishing sheet")
-    private static let uploadMediaManyItemsRemaining = NSLocalizedString("prepublishing.uploadMediaManyItemsRemaining", value: "%@ items remaining", comment: "Details label for a publish button state in the pre-publishing sheet")
+    static let publishingTo = NSLocalizedString(
+        "prepublishing.publishingTo",
+        value: "Publishing to",
+        comment: "Label in the header in the pre-publishing sheet"
+    )
+    static let publish = NSLocalizedString(
+        "prepublishing.publish",
+        value: "Publish",
+        comment: "Primary button label in the pre-publishing sheet"
+    )
+    static let schedule = NSLocalizedString(
+        "prepublishing.schedule",
+        value: "Schedule",
+        comment: "Primary button label in the pre-publishing shee"
+    )
+    static let publishDate = NSLocalizedString(
+        "prepublishing.publishDate",
+        value: "Publish Date",
+        comment: "Label for a cell in the pre-publishing sheet"
+    )
+    static let visibility = NSLocalizedString(
+        "prepublishing.visibility",
+        value: "Visibility",
+        comment: "Label for a cell in the pre-publishing sheet"
+    )
+    static let categories = NSLocalizedString(
+        "prepublishing.categories",
+        value: "Categories",
+        comment: "Label for a cell in the pre-publishing sheet"
+    )
+    static let tags = NSLocalizedString(
+        "prepublishing.tags",
+        value: "Tags",
+        comment: "Label for a cell in the pre-publishing sheet"
+    )
+    static let jetpackSocial = NSLocalizedString(
+        "prepublishing.jetpackSocial",
+        value: "Jetpack Social",
+        comment: "Label for a cell in the pre-publishing sheet"
+    )
+    static let immediately = NSLocalizedString(
+        "prepublishing.publishDateImmediately",
+        value: "Immediately",
+        comment: "Placeholder value for a publishing date in the prepublishing sheet when the date is not selected"
+    )
+    static let uploadingMedia = NSLocalizedString(
+        "prepublishing.uploadingMedia",
+        value: "Uploading media",
+        comment: "Title for a publish button state in the pre-publishing sheet"
+    )
+    private static let uploadMediaOneItemRemaining = NSLocalizedString(
+        "prepublishing.uploadMediaOneItemRemaining",
+        value: "%@ item remaining",
+        comment: "Details label for a publish button state in the pre-publishing sheet"
+    )
+    private static let uploadMediaManyItemsRemaining = NSLocalizedString(
+        "prepublishing.uploadMediaManyItemsRemaining",
+        value: "%@ items remaining",
+        comment: "Details label for a publish button state in the pre-publishing sheet"
+    )
     static func uploadMediaRemaining(count: Int) -> String {
-        String(format: count == 1 ? Strings.uploadMediaOneItemRemaining : Strings.uploadMediaManyItemsRemaining, count.description)
+        String(
+            format: count == 1 ? Strings.uploadMediaOneItemRemaining : Strings.uploadMediaManyItemsRemaining,
+            count.description
+        )
     }
-    static let mediaUploadFailedTitle = NSLocalizedString("prepublishing.mediaUploadFailedTitle", value: "Failed to upload media", comment: "Title for a publish button state in the pre-publishing sheet")
-    static let mediaUploadFailedDetailsMultipleFailures = NSLocalizedString("prepublishing.mediaUploadFailedDetails", value: "%@ items failed to upload", comment: "Details for a publish button state in the pre-publishing sheet; count as a parameter")
+    static let mediaUploadFailedTitle = NSLocalizedString(
+        "prepublishing.mediaUploadFailedTitle",
+        value: "Failed to upload media",
+        comment: "Title for a publish button state in the pre-publishing sheet"
+    )
+    static let mediaUploadFailedDetailsMultipleFailures = NSLocalizedString(
+        "prepublishing.mediaUploadFailedDetails",
+        value: "%@ items failed to upload",
+        comment: "Details for a publish button state in the pre-publishing sheet; count as a parameter"
+    )
 
     static let discardChangesTitle = NSLocalizedString(
         "prepublishing.discardChanges.title",

Original file line number	Diff line number	Diff line change
`@@ -143,7 +143,7 @@ private extension CustomPostEditorViewController {`
`143`	`143`	`style: .default,`
`144`	`144`	`handler: { [weak self] _ in`
`145`	`145`	`Task {`
`146`		`- await self?.save(publish: false)`
	`146`	`+ await self?.save()`
`147`	`147`	`}`
`148`	`148`	`}`
`149`	`149`	`)`
`@@ -170,7 +170,7 @@ private extension CustomPostEditorViewController {`
`170`	`170`	`attributes: enabled ? [] : [.disabled]`
`171`	`171`	`) { [weak self] _ in`
`172`	`172`	`Task {`
`173`		`- await self?.save(publish: false)`
	`173`	`+ await self?.save()`
`174`	`174`	`}`
`175`	`175`	`}`
`176`	`176`	`resolve([saveDraft])`
`@@ -197,7 +197,7 @@ private extension CustomPostEditorViewController {`
`197`	`197`	`} else {`
`198`	`198`	`return UIAction(title: PostEditorStrings.update) { [weak self] _ in`
`199`	`199`	`Task {`
`200`		`- await self?.save(publish: false)`
	`200`	`+ await self?.save()`
`201`	`201`	`}`
`202`	`202`	`}`
`203`	`203`	`}`
`@@ -228,12 +228,8 @@ private extension CustomPostEditorViewController {`
`228`	`228`	`blog: blog,`
`229`	`229`	`from: self,`
`230`	`230`	`completion: { [weak self] result in`
`231`		`- guard let self else { return }`
`232`		`- switch result {`
`233`		`- case .published:`
`234`		`- completion()`
`235`		`- case .cancelled:`
`236`		`- break`
	`231`	`+ if case .published = result {`
	`232`	`+ self?.completion()`
`237`	`233`	`}`
`238`	`234`	`}`
`239`	`235`	`)`
`@@ -248,21 +244,27 @@ private extension CustomPostEditorViewController {`
`248`	`244`
`249`	`245`	`private extension CustomPostEditorViewController {`
`250`	`246`
`251`		`- func save(publish: Bool) async {`
	`247`	`+ func save() async {`
`252`	`248`	`SVProgressHUD.show()`
`253`	`249`
	`250`	`+ // Capture whether this is a brand-new post (not yet on the server) so the`
	`251`	`+ // notice can distinguish "Draft saved" (just created) from "Post updated"`
	`252`	`+ // (edited an existing post). Any save of an already-existing post (draft`
	`253`	`+ // or published) reads as an update from the user's perspective.`
	`254`	`+ let isNewPost = post == nil`
	`255`	`+`
`254`	`256`	`do {`
`255`	`257`	`let data = try await editorViewController.getTitleAndContent()`
`256`	`258`	`try await editorService.save(`
`257`	`259`	`content: EditorContent(title: data.title, content: data.content),`
`258`		`- publish: publish`
	`260`	`+ publish: false`
`259`	`261`	`)`
`260`	`262`
`261`	`263`	`dismissHUDWithSuccess()`
`262`	`264`
`263`		`- if publish {`
`264`		`- completion()`
`265`		`- }`
	`265`	`+ let title = isNewPost ? CustomPostNoticeStrings.draftSaved : CustomPostNoticeStrings.postUpdated`
	`266`	`+ let subtitle = data.title.isEmpty ? nil : data.title`
	`267`	`+ Notice(title: title, message: subtitle, feedbackType: .success).post()`
`266`	`268`	`} catch {`
`267`	`269`	`SVProgressHUD.showError(withStatus: error.localizedDescription)`
`268`	`270`	`}`