Normalize remote post site IDs (#25773)

* Normalize remote post site IDs

* Add a release note

* Test numeric remote post site IDs

Author: crazytonyli

Modules/Sources/WordPressKitObjC/PostServiceRemoteREST.m

@@ -4,6 +4,7 @@
 #import "RemotePostTerm.h"
 #import "FilePart.h"
 #import "NSString+Helpers.h"
+#import "NSString+WPKitNumericValueHack.h"
 
 @import WordPressShared;
 @import WordPressKitModels;
@@ -396,7 +397,8 @@ - (RemotePost *)remotePostFromJSONDictionary:(NSDictionary *)jsonPost {
 + (RemotePost *)remotePostFromJSONDictionary:(NSDictionary *)jsonPost {
     RemotePost *post = [RemotePost new];
     post.postID = jsonPost[@"ID"];
-    post.siteID = jsonPost[@"site_ID"];
+    // Create and update responses return site_ID as a string, while read responses return a number.
+    post.siteID = [jsonPost[@"site_ID"] wpkit_numericValue];
     if (jsonPost[@"author"] != [NSNull null]) {
         NSDictionary *authorDictionary = jsonPost[@"author"];
         post.authorAvatarURL = authorDictionary[@"avatar_URL"];

RELEASE-NOTES.txt

@@ -6,6 +6,7 @@
 * [*] [internal] Stats widgets: migrate the site picker from SiriKit to App Intents [#25753]
 * [*] Fix Blogging Reminders text color in dark mode [#25780]
 * [*] Share extensions: Fix the site picker showing an error while sites are still loading [#25798]
+* [*] Share Extension: Fix a crash after uploading a post to WordPress.com [#25773]
 
 27.0
 -----

Tests/WordPressKitTests/WordPressKitTests/Tests/PostServiceRemoteRESTTests.m

@@ -26,6 +26,36 @@ - (PostServiceRemoteREST*)service
     return [[PostServiceRemoteREST alloc] initWithWordPressComRestApi:api siteID:siteID];
 }
 
+#pragma mark - Mapping posts
+
+- (void)testThatRemotePostMappingConvertsStringSiteIDToNumber
+{
+    NSDictionary *jsonPost = @{
+        @"ID": @1147,
+        @"site_ID": @"237072388"
+    };
+
+    RemotePost *post = [PostServiceRemoteREST remotePostFromJSONDictionary:jsonPost];
+
+    XCTAssertEqualObjects(post.postID, @1147);
+    XCTAssertEqualObjects(post.siteID, @237072388);
+    XCTAssertTrue([post.siteID isKindOfClass:[NSNumber class]]);
+}
+
+- (void)testThatRemotePostMappingPreservesNumericSiteID
+{
+    NSDictionary *jsonPost = @{
+        @"ID": @1147,
+        @"site_ID": @237072388
+    };
+
+    RemotePost *post = [PostServiceRemoteREST remotePostFromJSONDictionary:jsonPost];
+
+    XCTAssertEqualObjects(post.postID, @1147);
+    XCTAssertEqualObjects(post.siteID, @237072388);
+    XCTAssertTrue([post.siteID isKindOfClass:[NSNumber class]]);
+}
+
 #pragma mark - Getting posts by ID
 
 - (void)testThatGetPostWithIDWorks