Merge pull request #19200 from wordpress-mobile/issue/13370-jetpack-stats-file-downloads

Stats: Hide file downloads stats section for Jetpack sites

Author: hassaanelgarem

RELEASE-NOTES.txt

@@ -3,6 +3,7 @@
 * [*] [Jetpack-only] Recommend App: you can now share the Jetpack app with your friends. [#19174]
 * [*] [Jetpack-only] Feature Announcements: new features are highlighted via the What's New modals. [#19176]
 * [*] Pages List: Fixed an issue where the app would freeze when opening the pages list if one of the featured images is a GIF. [#19184]
+* [*] Stats: Fixed an issue where File Downloads section was being displayed for Jetpack sites even though it's not supported. [#19200]
 
 
 20.5

WordPress/Classes/Models/Blog.h

@@ -95,6 +95,8 @@ typedef NS_ENUM(NSUInteger, BlogFeature) {
     BlogFeatureLoomEmbed,
     /// Does the blog support Smartframe embed block?
     BlogFeatureSmartframeEmbed,
+    /// Does the blog support File Downloads section in stats?
+    BlogFeatureFileDownloadsStats,
 
 };
 

WordPress/Classes/Models/Blog.m

@@ -596,6 +596,8 @@ - (BOOL)supports:(BlogFeature)feature
             return [self supportsEmbedVariation: @"9.0"];
         case BlogFeatureSmartframeEmbed:
             return [self supportsEmbedVariation: @"10.2"];
+        case BlogFeatureFileDownloadsStats:
+            return [self isHostedAtWPcom];
     }
 }
 

WordPress/Classes/ViewRelated/Stats/Helpers/SiteStatsInformation.swift

@@ -13,6 +13,7 @@ import Foundation
     @objc var siteID: NSNumber?
     @objc var siteTimeZone: TimeZone?
     @objc var oauth2Token: String?
+    @objc var supportsFileDownloads: Bool = true
 
     func updateTimeZone() {
         let context = ContextManager.shared.mainContext

WordPress/Classes/ViewRelated/Stats/Period Stats/SiteStatsPeriodViewModel.swift

@@ -195,16 +195,18 @@ class SiteStatsPeriodViewModel: Observable {
             }, error: {
                 return errorBlock(.periodVideos)
         }))
-        tableRows.append(contentsOf: blocks(for: .topFileDownloads,
-                                            type: .period,
-                                            status: store.topFileDownloadsStatus,
-                                            block: { [weak self] in
-                                                return self?.fileDownloadsTableRows() ?? errorBlock(.periodFileDownloads)
-            }, loading: {
-                return loadingBlock(.periodFileDownloads)
-            }, error: {
-                return errorBlock(.periodFileDownloads)
-        }))
+        if SiteStatsInformation.sharedInstance.supportsFileDownloads {
+            tableRows.append(contentsOf: blocks(for: .topFileDownloads,
+                                                type: .period,
+                                                status: store.topFileDownloadsStatus,
+                                                block: { [weak self] in
+                                                    return self?.fileDownloadsTableRows() ?? errorBlock(.periodFileDownloads)
+                }, loading: {
+                    return loadingBlock(.periodFileDownloads)
+                }, error: {
+                    return errorBlock(.periodFileDownloads)
+            }))
+        }
 
         tableRows.append(TableFooterRow())
 

WordPress/Classes/ViewRelated/Stats/StatsViewController.m

@@ -130,6 +130,7 @@ - (void)initStats
 
         SiteStatsInformation.sharedInstance.oauth2Token = self.blog.account.authToken;
         SiteStatsInformation.sharedInstance.siteID = self.blog.dotComID;
+        SiteStatsInformation.sharedInstance.supportsFileDownloads = [self.blog supports:BlogFeatureFileDownloadsStats];
 
         [self addStatsViewControllerToView];
         [self initializeStatsWidgetsIfNeeded];