Merge pull request #17869 from wordpress-mobile/fix/17752-restore_comment

Threaded comment moderation: don't show non-approved cached comments

Author: ScoutHarris

WordPress/Classes/ViewRelated/Reader/Comments/ReaderCommentsViewController.h

@@ -31,4 +31,9 @@ typedef NS_ENUM(NSUInteger, ReaderCommentsSource) {
 /// Navigates to the specified comment when the view appears
 @property (nonatomic, strong) NSNumber *navigateToCommentID;
 
+
+// Comment moderation support.
+@property (nonatomic, assign, readwrite) BOOL commentModified;
+- (void)refreshAfterCommentModeration;
+
 @end

WordPress/Classes/ViewRelated/Reader/Comments/ReaderCommentsViewController.m

@@ -144,6 +144,7 @@ - (void)viewDidLoad
 {
     [super viewDidLoad];
     self.view.backgroundColor = [UIColor murielBasicBackground];
+    self.commentModified = NO;
 
     [self checkIfLoggedIn];
 
@@ -195,6 +196,11 @@ - (void)viewWillDisappear:(BOOL)animated
 {
     [super viewWillDisappear:animated];
     [self dismissNotice];
+    
+    if (self.commentModified) {
+        // Don't post the notification until the view is being dismissed to avoid purging cached comments prematurely.
+        [self postCommentModifiedNotification];
+    }
 
 #pragma clang diagnostic push
 #pragma clang diagnostic ignored "-Wunused-result"
@@ -933,6 +939,12 @@ - (void)refreshNoResultsView
     [self.noResultsViewController didMoveToParentViewController:self];
 }
 
+- (void)refreshAfterCommentModeration
+{
+    [self.tableViewHandler refreshTableView];
+    [self refreshNoResultsView];
+}
+
 - (void)updateTableViewForAttachments
 {
     [self.tableView performBatchUpdates:nil completion:nil];
@@ -1199,9 +1211,11 @@ - (NSFetchRequest *)fetchRequest
         return nil;
     }
 
-    NSFetchRequest *fetchRequest = [[NSFetchRequest alloc] initWithEntityName:NSStringFromClass([Comment class])];
-    fetchRequest.predicate = [NSPredicate predicateWithFormat:@"post = %@", self.post];
+    // Moderated comments could still be cached, so filter out non-approved comments.
+    NSString *approvedStatus = [Comment descriptionFor:CommentStatusTypeApproved];
 
+    NSFetchRequest *fetchRequest = [[NSFetchRequest alloc] initWithEntityName:NSStringFromClass([Comment class])];
+    fetchRequest.predicate = [NSPredicate predicateWithFormat:@"post = %@ AND status = %@", self.post, approvedStatus];
     NSSortDescriptor *sortDescriptor = [[NSSortDescriptor alloc] initWithKey:@"hierarchy" ascending:YES];
     [fetchRequest setSortDescriptors:@[sortDescriptor]];
 
@@ -1225,12 +1239,6 @@ - (void)configureCell:(UITableViewCell *)aCell atIndexPath:(NSIndexPath *)indexP
     }
 
     Comment *comment = [self.tableViewHandler.resultsController objectAtIndexPath:indexPath];
-    // The user may have moderated a comment, but it is not removed from the post yet.
-    // So check the status to be sure only Approved comments are displayed.
-    if (![comment.status isEqualToString:[Comment descriptionFor:CommentStatusTypeApproved]]) {
-        return;
-    }
-    
     if ([self newCommentThreadEnabled]) {
         CommentContentTableViewCell *cell = (CommentContentTableViewCell *)aCell;
         [self configureContentCell:cell comment:comment indexPath:indexPath handler:self.tableViewHandler];
@@ -1290,8 +1298,6 @@ - (void)configureCell:(UITableViewCell *)aCell atIndexPath:(NSIndexPath *)indexP
         };
     }
 
-
-
     NSAttributedString *attrStr = [self cacheContentForComment:comment];
     [cell configureCellWithComment:comment attributedString:attrStr];
 }

WordPress/Classes/ViewRelated/Reader/Comments/ReaderCommentsViewController.swift

@@ -142,6 +142,12 @@ extension NSNotification.Name {
         WPAnalytics.trackReader(.readerArticleCommentsOpened, properties: properties)
     }
 
+    // MARK: - Notification
+
+    @objc func postCommentModifiedNotification() {
+        NotificationCenter.default.post(name: .ReaderCommentModifiedNotification, object: nil)
+    }
+
 }
 
 // MARK: - Popover Presentation Delegate
@@ -190,13 +196,13 @@ private extension ReaderCommentsViewController {
         return [
             [
                 .unapprove { [weak self] in
-                    self?.moderateComment(comment, status: .pending, handler: handler)
+                    self?.moderateComment(comment, status: .pending)
                 },
                 .spam { [weak self] in
-                    self?.moderateComment(comment, status: .spam, handler: handler)
+                    self?.moderateComment(comment, status: .spam)
                 },
                 .trash { [weak self] in
-                    self?.moderateComment(comment, status: .unapproved, handler: handler)
+                    self?.moderateComment(comment, status: .unapproved)
                 }
             ],
             [
@@ -223,7 +229,7 @@ private extension ReaderCommentsViewController {
             CommentAnalytics.trackCommentEdited(comment: comment)
 
             self?.commentService.uploadComment(comment, success: {
-                NotificationCenter.default.post(name: .ReaderCommentModifiedNotification, object: nil)
+                self?.commentModified = true
 
                 // update the thread again in case the approval status changed.
                 tableView.reloadRows(at: [indexPath], with: .automatic)
@@ -237,23 +243,18 @@ private extension ReaderCommentsViewController {
         present(navigationControllerToPresent, animated: true)
     }
 
-    func moderateComment(_ comment: Comment, status: CommentStatusType, handler: WPTableViewHandler) {
+    func moderateComment(_ comment: Comment, status: CommentStatusType) {
         let successBlock: (String) -> Void = { [weak self] noticeText in
-            NotificationCenter.default.post(name: .ReaderCommentModifiedNotification, object: nil)
-
-            // Adjust the ReaderPost's comment count.
-            if let post = self?.post, let commentCount = post.commentCount?.intValue {
-                let adjustment = (status == .approved) ? 1 : -1
-                post.commentCount = NSNumber(value: commentCount + adjustment)
-            }
+            self?.commentModified = true
+            self?.refreshAfterCommentModeration()
 
-            // Refresh the UI. The table view handler is needed because the fetched results delegate is set to nil.
-            handler.refreshTableViewPreservingOffset()
+            // Dismiss any old notices to avoid stacked Undo notices.
+            self?.dismissNotice()
 
             // If the status is Approved, the user has undone a comment moderation.
             // So don't show the Undo option in this case.
             (status == .approved) ? self?.displayNotice(title: noticeText) :
-                                    self?.showActionableNotice(title: noticeText, comment: comment, handler: handler)
+                                    self?.showActionableNotice(title: noticeText, comment: comment)
         }
 
         switch status {
@@ -288,12 +289,12 @@ private extension ReaderCommentsViewController {
         }
     }
 
-    func showActionableNotice(title: String, comment: Comment, handler: WPTableViewHandler) {
+    func showActionableNotice(title: String, comment: Comment) {
         displayActionableNotice(title: title,
                                 actionTitle: .undoActionTitle,
                                 actionHandler: { [weak self] _ in
             // Set the Comment's status back to Approved when the user selects Undo on the notice.
-            self?.moderateComment(comment, status: .approved, handler: handler)
+            self?.moderateComment(comment, status: .approved)
         })
     }
 

WordPress/Classes/ViewRelated/Reader/Detail/ReaderDetailViewController.swift

@@ -382,12 +382,16 @@ class ReaderDetailViewController: UIViewController, ReaderDetailView {
             return
         }
 
+        // Moderated comments could still be cached, so filter out non-approved comments.
+        let approvedStatus = Comment.descriptionFor(.approved)
+        let approvedComments = comments.filter({ $0.status == approvedStatus})
+
         // Set the delegate here so the table isn't shown until fetching is complete.
         commentsTableView.delegate = commentsTableViewDelegate
         commentsTableView.dataSource = commentsTableViewDelegate
 
         commentsTableViewDelegate.updateWith(post: post,
-                                             comments: comments,
+                                             comments: approvedComments,
                                              totalComments: totalComments,
                                              presentingViewController: self,
                                              buttonDelegate: self)