Stop shipping widget configuration translations for iOS 17

iOS 18 and later resolve the widget configuration UI's App Intents strings against the app bundle, whose GlotPress-managed Localizable.strings already carries the ios-widget. keys in every locale, so the static copies in the extension bundle only served iOS 17 (verified on 17.5/18.6/26.5 simulators, including that iOS 17 has no fallback to the app bundle). The iOS 17 user base no longer justifies maintaining 34 hand-refreshed translation snapshots, so its widget configuration UI now shows the English defaults.

Author: crazytonyli

Modules/Sources/JetpackStatsWidgetsCore/AppIntents/SelectSiteIntent.swift

@@ -12,24 +12,34 @@ import AppIntents
 /// `ios-widget.` prefix, and the downloaded translations land in the app's
 /// `Localizable.strings` under those prefixed keys.
 ///
-/// The keys must resolve in two bundles, because the OS picks a different one depending on
-/// version (verified on simulators): iOS 26 resolves the widget configuration UI's strings
-/// against the app bundle (whose GlotPress-managed `Localizable.strings` carries the prefixed
-/// keys in every locale), while iOS 17 resolves against the widget extension bundle, which
-/// ships static copies of the same prefixed keys in
-/// `Sources/JetpackStatsWidgets/Resources/<locale>.lproj/Localizable.strings`.
-/// A nested SPM package resource bundle is never consulted, so the strings cannot live in
-/// this package.
+/// iOS 18 and later resolve the widget configuration UI's strings against the app bundle,
+/// whose GlotPress-managed `Localizable.strings` carries the prefixed keys in every locale
+/// (verified on simulators; a nested SPM package resource bundle is never consulted).
+/// iOS 17 resolves against the widget extension bundle only, with no fallback to the app
+/// bundle, so it shows the English default values; we accept English there rather than
+/// shipping per-locale copies in the extension.
 public struct SelectSiteIntent: WidgetConfigurationIntent, CustomIntentMigratedAppIntent {
     public static let intentClassName = "SelectSiteIntent"
 
-    public static let title = LocalizedStringResource("ios-widget.gpCwrM", defaultValue: "Select Site")
+    public static let title = LocalizedStringResource(
+        "ios-widget.gpCwrM",
+        defaultValue: "Select Site",
+        table: "Localizable",
+        comment: "Title shown when choosing a site for a widget."
+    )
 
     // The legacy intent was ineligible for Siri suggestions; keep this
     // configuration-only intent out of Shortcuts and Spotlight the same way.
     public static let isDiscoverable = false
 
-    @Parameter(title: LocalizedStringResource("ios-widget.ILcGmf", defaultValue: "Site"))
+    @Parameter(
+        title: LocalizedStringResource(
+            "ios-widget.ILcGmf",
+            defaultValue: "Site",
+            table: "Localizable",
+            comment: "Label for the site picker when configuring a widget."
+        )
+    )
     public var site: SiteEntity?
 
     public init() {}

Modules/Sources/JetpackStatsWidgetsCore/AppIntents/SiteEntity.swift

@@ -7,11 +7,16 @@ import Foundation
 /// the `identifier` of the legacy SiriKit `Site` object so that widget configurations created
 /// before the App Intents migration keep resolving to the same site.
 ///
-/// The "ios-widget.ILcGmf" localization key resolves against the app bundle on iOS 26 and
-/// the widget extension bundle on iOS 17; see `SelectSiteIntent` for the details.
+/// The "ios-widget.ILcGmf" localization key resolves against the app bundle on iOS 18 and
+/// later; see `SelectSiteIntent` for the details.
 public struct SiteEntity: AppEntity {
     public static let typeDisplayRepresentation = TypeDisplayRepresentation(
-        name: LocalizedStringResource("ios-widget.ILcGmf", defaultValue: "Site")
+        name: LocalizedStringResource(
+            "ios-widget.ILcGmf",
+            defaultValue: "Site",
+            table: "Localizable",
+            comment: "Name of the site entity used by widgets and App Intents."
+        )
     )
 
     public static var defaultQuery: SiteEntityQuery { SiteEntityQuery() }