Skip to content

Commit 73fef12

Browse files
committed
Fix flaky unit tests caused by randomly generated dotComID
1 parent 8b828ae commit 73fef12

2 files changed

Lines changed: 2 additions & 1 deletion

File tree

WordPress/Classes/Models/Blog.h

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -121,6 +121,7 @@ typedef NS_ENUM(NSInteger, SiteVisibility) {
121121
@interface Blog : NSManagedObject
122122

123123
@property (nonatomic, strong, readwrite, nullable) NSNumber *blogID __deprecated_msg("Use dotComID instead");
124+
/// WordPress.com site ID stored as signed 32-bit integer.
124125
@property (nonatomic, strong, readwrite, nullable) NSNumber *dotComID;
125126
@property (nonatomic, strong, readwrite, nullable) NSString *xmlrpc;
126127
@property (nonatomic, strong, readwrite, nullable) NSString *apiKey;

WordPress/WordPressTest/BlogBuilder.swift

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -17,7 +17,7 @@ final class BlogBuilder {
1717
blog = NSEntityDescription.insertNewObject(forEntityName: Blog.entityName(), into: context) as! Blog
1818

1919
// Non-null properties in Core Data
20-
blog.dotComID = NSNumber(value: arc4random_uniform(UInt32.max))
20+
blog.dotComID = NSNumber(value: arc4random_uniform(999_999))
2121
blog.url = "https://\(blog.dotComID!).example.com"
2222
blog.xmlrpc = "https://\(blog.dotComID!).example.com/xmlrpc.php"
2323
}

0 commit comments

Comments
 (0)