Split the catalog flow into download + localize lanes

Run a download then a localize as separate fastlane invocations:
- download_catalog_strings — pull GlotPress translations into the *.lproj dirs (scoped by locales:)
- localize_catalog — scan + fold the downloaded strings + AI-fill into Localizable.xcstrings

Replaces the single download_localized_catalog lane (and its skip_download flag): download
once, re-localize as many times as you like without re-downloading.

Author: jkmassel

fastlane/lanes/localization_catalog.rb

@@ -82,37 +82,46 @@
     end
   end
 
-  # Builds Localizable.xcstrings, the future regular-string backing store, end to end:
-  #   1. scan the code into the English catalog (generate_strings_catalog),
-  #   2. download the current GlotPress translations and fold them in (human => translated),
-  #   3. AI-fill the cells GlotPress left empty (=> needs_review) — see CatalogStrings.fold_translations!.
-  # Uploading the AI drafts back to GlotPress as needs-review for human review (the eventual "step 4") is a
-  # separate step, not done here — it builds on the existing GlotPress import integration (cf.
-  # gp_update_metadata_source). For now the machine cells live in the catalog as needs_review.
+  # STEP 2 (download) — pull the current GlotPress translations for the given locales into their `*.lproj` dirs,
+  # ready for `localize_catalog` to fold. A thin, scoped wrapper around the GlotPress download (the full
+  # `download_localized_strings` works too, if you want every locale plus the plural fold). Scope with
+  # `locales:fr,de`; default is all ship locales. Doesn't commit — the `.strings` are transient input.
+  desc 'Download step: pull GlotPress translations into the *.lproj dirs (then run localize_catalog)'
+  lane :download_catalog_strings do |options|
+    locales = catalog_target_locales(options[:locales])
+    ios_download_strings_files_from_glotpress(
+      project_url: GLOTPRESS_APP_STRINGS_PROJECT_URL,
+      locales: locales,
+      download_dir: File.join(PROJECT_ROOT_FOLDER, 'WordPress', 'Resources')
+    )
+    UI.success("Downloaded GlotPress translations for #{locales.values.uniq.size} locale(s). Next: run localize_catalog (same locales:).")
+  end
+
+  # LOCALIZE (steps 1 + 3) — build Localizable.xcstrings from the ALREADY-DOWNLOADED strings: scan the code into
+  # the English catalog, fold the GlotPress translations in (human => translated), and AI-fill the cells they
+  # leave empty (=> needs_review). Run `download_catalog_strings` (or `download_localized_strings`) first.
+  #
+  # Uploading the AI drafts back to GlotPress as needs-review (the eventual "step 4") is a separate step, not
+  # done here — it builds on the existing GlotPress import integration (cf. gp_update_metadata_source).
   #
   # STAGED, NOT SHIPPED: Localizable.xcstrings isn't the runtime store yet (the app still ships
   # Localizable.strings), so this only pre-populates it for the cutover — it changes nothing users see.
   #
-  # MANUAL ONLY — deliberately not wired into download_localized_strings or any CI step: it runs xcstringstool
-  # extraction, downloads from GlotPress, calls the translation API (cost), and commits a large catalog. Set
-  # ANTHROPIC_API_KEY for step 3; scope a cheap run with `locales:fr` (and add `skip_download:true` to reuse the
-  # committed .strings instead of re-downloading).
-  desc 'Builds Localizable.xcstrings: scan code, fold GlotPress translations, AI-fill the rest (staged; manual, not CI)'
-  lane :download_localized_catalog do |options|
-    resources_dir = File.join(PROJECT_ROOT_FOLDER, 'WordPress', 'Resources')
-    locales = catalog_target_locales(options[:locales]) # all ship locales, or the `locales:fr,de` subset
+  # MANUAL ONLY — not wired into download_localized_strings or any CI step: it runs xcstringstool extraction,
+  # calls the translation API (cost), and commits a large catalog. Set ANTHROPIC_API_KEY for the AI rung; scope
+  # a cheap run with `locales:fr`.
+  desc 'Localize step: build Localizable.xcstrings from downloaded strings — scan + fold + AI-fill (staged; manual, not CI)'
+  lane :localize_catalog do |options|
+    locales = catalog_target_locales(options[:locales])
 
     # 1. Scan the code into the English catalog (create / update + reconcile changed sources).
     generate_strings_catalog
 
-    # 2. Download the current GlotPress translations for those locales (skip to reuse the committed .strings).
-    download_catalog_strings(resources_dir, locales) unless catalog_flag?(options[:skip_download])
-
-    # 2b + 3. Fold the human translations in (=> translated), then AI-fill the cells GlotPress left empty.
+    # Fold the downloaded human translations in (=> translated), then (3) AI-fill the cells they leave empty.
     catalog = JSON.parse(File.read(LOCALIZABLE_CATALOG))
     written = CatalogStrings.fold_translations!(
       catalog,
-      translations_by_locale: catalog_translations_by_locale(resources_dir),
+      translations_by_locale: catalog_translations_by_locale(File.join(PROJECT_ROOT_FOLDER, 'WordPress', 'Resources')),
       locales: locales.values.uniq,
       ai_translator: catalog_ai_translator
     )
@@ -253,20 +262,6 @@ def catalog_target_locales(spec)
     selected
   end
 
-  # Step 2: download the current GlotPress translations for the given locales into their `*.lproj` dirs.
-  def download_catalog_strings(resources_dir, locales)
-    ios_download_strings_files_from_glotpress(
-      project_url: GLOTPRESS_APP_STRINGS_PROJECT_URL,
-      locales: locales,
-      download_dir: resources_dir
-    )
-  end
-
-  # A fastlane CLI flag, which arrives as a string ("true"/"1"/"yes") or a real boolean.
-  def catalog_flag?(value)
-    %w[true 1 yes].include?(value.to_s.strip.downcase)
-  end
-
   # { lproj => { key => human value } } from the downloaded translation `.strings`. The flat plural keys present
   # in these files aren't catalog keys, so the fold ignores them (they belong to Plurals.xcstrings).
   def catalog_translations_by_locale(dir)