Add cross-platform Swift package tests for macOS (#25344)

* Add cross-platform Package.swift for macOS testing

Defines a subset of modules that build and test on macOS without
Xcode, enabling `swift test` from the repo root. Modules can be
incrementally added here as they become cross-platform.

Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>

* Add WordPressKitObjCUtils, WordPressKitModels, and WordPressKitObjC to cross-platform package

Replace unnecessary UIKit imports with Foundation in Obj-C headers
that only use Foundation types. Remove stale UIKit import from
FeatureFlagRemote.swift.

Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>

* Split WordPressShared into cross-platform and UIKit-only modules

Create WordPressSharedObjCUI and WordPressSharedUI for UIKit-dependent
code, keeping WordPressSharedObjC and WordPressShared cross-platform.
Update all import statements across the codebase accordingly.

* Decouple WordPressKit from UIKit

Introduce DeviceInformation struct to replace direct UIDevice usage in
NotificationSettingsServiceRemote. Use ProcessInfo for OS version in
SessionDetails. Guard UIKit-only code with #if canImport(UIKit) in
HTTPAuthenticationAlertController, UIDevice+Extensions,
NSMutableParagraphStyle+extensions, GravatarServiceRemote (upload),
PluginDirectoryEntry (HTML text extraction), and
SiteDesignServiceRemote (screen scale).

Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>

* Add WordPressShared and WordPressKit to cross-platform package

Add WordPressSharedObjC, WordPressShared, WordPressKit, and
WordPressSharedTests to the root Package.swift for macOS testing.

Fix cross-platform build issues: remove unused MobileCoreServices
import from URL+Helpers, guard String.accessibilityLabel usage in
Double+Stats with #if canImport(UIKit), and remove unused
WordPressSharedObjC import from String+RemovingMatches.

Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>

* Add Buildkite job to run cross-platform Swift package tests

Runs `swift test` from the repository root to verify that cross-platform
modules build and pass tests on macOS without Xcode.

Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>

* Reconcile cross-platform module split with trunk

Rebasing onto trunk surfaced drift in the module graph the split targets.
The app builds unchanged; these adapt the split + cross-platform package to
302 commits of trunk evolution.

Module graph:
- Root Package.swift: drop the removed WordPressKitObjCUtils target/deps
  (folded into WordPressSharedObjC on trunk); align WordPressShared deps
  with trunk (BuildSettingsKit/Logging/SwiftSoup, no Reachability pod);
  bump wordpress-rs to 0.6.0 to match the WordPressAPI surface trunk's
  WordPressCore now uses; exclude JetpackStatsWidgetsCore's iOS-only
  AppIntents (SelectSiteIntent/SiteEntity) and its test from the macOS build.
- Modules/Package.swift: graft WordPressSharedUI/WordPressSharedObjCUI
  targets and wire them into consumers that gained WordPressSharedUI usage
  (AztecExtensions, FormattableContentKit, JetpackStats, WordPressReader,
  JetpackSocial, WordPressData, App/Keystone, Share/Draft extensions, tests).

Imports:
- Add `import WordPressSharedUI` to trunk-added callers of WPUserAgent
  (WordPressData Blog, JetpackSocial) and the reachability alert helpers
  (Jetpack Restore/Backup options).
- Add explicit `@import WordPressSharedObjC` to WordPressKitObjC files using
  `wp_map:` — the ObjC-side transitive re-export through WordPressShared no
  longer resolves once it also re-exports WordPressSharedObjCUI.
- Replace a stray `#import <UIKit/UIKit.h>` with Foundation in
  NSString+WPKitNumericValueHack.h (Foundation-only header) so WordPressKitObjC
  builds on macOS.
- Make the keychain logger label nil-safe: `Bundle.main.bundleIdentifier`
  is nil in the SPM test runner and crashed the cross-platform test suite.

Verified: `swift build` + `swift test` (macOS cross-platform package, all
tests pass) and the full WordPress iOS app + Share/Draft/NotificationService
extensions build.

* Reference the Modules package instead of re-declaring cross-platform targets

The cross-platform Package.swift re-declared 14 targets that already live in
Modules/Package.swift, differing only in their macOS-stripped dependency lists
— a standing source of drift. Depend on the Modules package and reference its
products instead, so each target is defined once.

This requires Modules to be macOS-aware:
- Add a .macOS(.v14) floor, which satisfies the highest dependency floors
  (GutenbergKit 14, WordPressAPI 13, Gravatar 12) and clears platform-floor
  validation for the whole graph.
- Gate the WordPressShared -> WordPressSharedObjCUI edge to non-macOS platforms;
  it is UIKit-only.
- Wrap JetpackStatsWidgetsCore's iOS-only AppIntents in #if os(iOS).

The root manifest drops from 149 to 51 lines and now inherits Modules'
dependency changes automatically. Trade-off: `swift test` resolves the full
Modules dependency graph (40 packages) rather than a curated 5.

Verified: swift build + swift test on macOS (77 tests) and the WordPress iOS
app build.

---------

Co-authored-by: Claude Opus 4.6 <noreply@anthropic.com>

Author: jkmassel

.buildkite/commands/run-swift-package-tests.sh

@@ -0,0 +1,8 @@
+#!/bin/bash -eu
+
+if "$(dirname "${BASH_SOURCE[0]}")/should-skip-job.sh" --job-type validation; then
+  exit 0
+fi
+
+echo "--- :swift: Running cross-platform Swift package tests"
+swift test

.buildkite/pipeline.yml

@@ -80,6 +80,13 @@ steps:
   - group: "🔬 Unit Tests"
     key: unit_tests_group
     steps:
+      - label: "🔬 :swift: Swift Package Tests"
+        command: .buildkite/commands/run-swift-package-tests.sh
+        plugins: [$CI_TOOLKIT_PLUGIN]
+        notify:
+          - github_commit_status:
+              context: "Swift Package Tests"
+
       - label: "🔬 :wordpress: Unit Tests"
         command: ".buildkite/commands/run-unit-tests.sh"
         depends_on: "build_wordpress"

Modules/Package.swift

@@ -5,7 +5,8 @@ import PackageDescription
 let package = Package(
     name: "Modules",
     platforms: [
-        .iOS(.v17)
+        .iOS(.v17),
+        .macOS(.v14)
     ],
     products: XcodeSupport.products + [
         .library(name: "AsyncImageKit", targets: ["AsyncImageKit"]),
@@ -84,6 +85,7 @@ let package = Package(
             name: "AztecExtensions",
             dependencies: [
                 "WordPressShared",
+                "WordPressSharedUI",
                 .product(name: "Gridicons", package: "Gridicons-iOS"),
                 .product(name: "Aztec", package: "AztecEditor-iOS")
             ],
@@ -103,6 +105,7 @@ let package = Package(
             name: "FormattableContentKit",
             dependencies: [
                 "WordPressShared",
+                "WordPressSharedUI",
                 "WordPressUI",
                 // TODO: Remove — It's here just for a NSMutableParagraphStyle init helper
                 "WordPressKit",
@@ -116,7 +119,8 @@ let package = Package(
             dependencies: [
                 "WordPressUI",
                 "WordPressKit",
-                "WordPressShared"
+                "WordPressShared",
+                "WordPressSharedUI"
             ],
             resources: [.process("Resources")]
         ),
@@ -131,6 +135,7 @@ let package = Package(
                 "AsyncImageKit",
                 "DesignSystem",
                 "WordPressShared",
+                "WordPressSharedUI",
                 "WordPressUI",
                 "WordPressCore",
                 .product(name: "WordPressAPI", package: "wordpress-rs"),
@@ -227,7 +232,13 @@ let package = Package(
         .target(name: "WordPressLegacy", dependencies: ["DesignSystem", "WordPressShared"]),
         .target(
             name: "WordPressSharedObjC",
+            swiftSettings: [.swiftLanguageMode(.v5)]
+        ),
+        .target(
+            name: "WordPressSharedObjCUI",
+            dependencies: ["WordPressSharedObjC"],
             resources: [.process("Resources")],
+            publicHeadersPath: "include",
             swiftSettings: [.swiftLanguageMode(.v5)]
         ),
         .target(
@@ -237,11 +248,24 @@ let package = Package(
                 .product(name: "Logging", package: "swift-log"),
                 .product(name: "SwiftSoup", package: "SwiftSoup"),
                 .target(name: "SFHFKeychainUtils"),
-                .target(name: "WordPressSharedObjC")
+                .target(name: "WordPressSharedObjC"),
+                // UIKit-only; drop on macOS so WordPressShared builds cross-platform.
+                .target(
+                    name: "WordPressSharedObjCUI",
+                    condition: .when(platforms: [.iOS, .macCatalyst, .tvOS, .watchOS, .visionOS])
+                )
             ],
             resources: [.process("Resources")],
             swiftSettings: [.swiftLanguageMode(.v5)]
         ),
+        .target(
+            name: "WordPressSharedUI",
+            dependencies: [
+                "WordPressShared",
+                "WordPressSharedObjCUI"
+            ],
+            swiftSettings: [.swiftLanguageMode(.v5)]
+        ),
         .target(name: "WordPressTesting", resources: [.process("Resources")]),
         .target(
             name: "WordPressUI",
@@ -293,6 +317,7 @@ let package = Package(
                 "FormattableContentKit",
                 "SFHFKeychainUtils",
                 "WordPressShared",
+                "WordPressSharedUI",
                 "WordPressKit",
                 "WordPressUI",
                 .product(name: "CocoaLumberjack", package: "CocoaLumberjack"),
@@ -315,6 +340,7 @@ let package = Package(
                 "AsyncImageKit",
                 "WordPressUI",
                 "WordPressShared",
+                "WordPressSharedUI",
                 .product(name: "SwiftSoup", package: "SwiftSoup")
             ],
             resources: [.process("Resources")]
@@ -346,7 +372,7 @@ let package = Package(
         ),
         .testTarget(
             name: "WordPressSharedTests",
-            dependencies: [.target(name: "WordPressShared")],
+            dependencies: [.target(name: "WordPressShared"), .target(name: "WordPressSharedUI")],
             swiftSettings: [.swiftLanguageMode(.v5)]
         ),
         .testTarget(
@@ -361,12 +387,15 @@ let package = Package(
         ),
         .testTarget(
             name: "WordPressSharedObjCTests",
-            dependencies: [.target(name: "WordPressShared"), .target(name: "WordPressTesting")],
+            dependencies: [
+                .target(name: "WordPressShared"), .target(name: "WordPressSharedObjCUI"),
+                .target(name: "WordPressTesting")
+            ],
             swiftSettings: [.swiftLanguageMode(.v5)]
         ),
         .testTarget(
             name: "WordPressUIUnitTests",
-            dependencies: [.target(name: "WordPressUI")],
+            dependencies: [.target(name: "WordPressUI"), .target(name: "WordPressSharedUI")],
             swiftSettings: [.swiftLanguageMode(.v5)]
         ),
         .testTarget(name: "WordPressCoreTests", dependencies: [.target(name: "WordPressCore")]),
@@ -420,6 +449,7 @@ enum XcodeSupport {
             "SFHFKeychainUtils",
             "ShareExtensionCore",
             "WordPressShared",
+            "WordPressSharedUI",
             "WordPressUI",
             "TextBundle",
             "TracksMini",
@@ -464,6 +494,8 @@ enum XcodeSupport {
             "WordPressFlux",
             "WordPressIntelligence",
             "WordPressShared",
+            "WordPressSharedUI",
+            "WordPressSharedObjCUI",
             "WordPressLegacy",
             "WordPressMediaLibrary",
             "WordPressReader",
@@ -514,6 +546,7 @@ enum XcodeSupport {
                     "WordPressData",
                     "WordPressKit",
                     "WordPressShared",
+                    "WordPressSharedUI",
                     "WordPressUI",
                     .product(name: "Gravatar", package: "Gravatar-SDK-iOS"),
                     .product(name: "WordPressAPI", package: "wordpress-rs")

Modules/Sources/AztecExtensions/Header+WordPress.swift

@@ -2,6 +2,7 @@ import Foundation
 import Aztec
 import Gridicons
 import WordPressShared
+import WordPressSharedUI
 
 // MARK: - Header and List presentation extensions
 //

Modules/Sources/FormattableContentKit/Styles/SnippetsContentStyles.swift

@@ -1,4 +1,5 @@
 import WordPressShared
+import WordPressSharedUI
 
 public class SnippetsContentStyles: FormattableContentStyles {
     public var attributes: [NSAttributedString.Key: Any] {

Modules/Sources/FormattableContentKit/Styles/SubjectContentStyles.swift

@@ -1,4 +1,5 @@
 import WordPressShared
+import WordPressSharedUI
 
 public class SubjectContentStyles: FormattableContentStyles {
     public var attributes: [NSAttributedString.Key: Any] {

Modules/Sources/FormattableContentKit/Styles/WPStyleGuide+Notifications.swift

@@ -3,6 +3,7 @@ import Foundation
 import Gridicons
 import UIKit
 import WordPressShared
+import WordPressSharedUI
 import WordPressKit // FIXME: Here just for the NSMutableParagraphStyle custom init
 import WordPressUI
 

Modules/Sources/JetpackSocial/Views/SocialOAuthWebViewController.swift

@@ -2,6 +2,7 @@ import Logging
 import UIKit
 @preconcurrency import WebKit
 import WordPressShared
+import WordPressSharedUI
 
 /// A minimal `WKWebView` host for the Publicize OAuth kick-off flow.
 ///

Modules/Sources/JetpackStats/StatsRouter.swift

@@ -2,6 +2,7 @@ import SwiftUI
 import UIKit
 import SafariServices
 import WordPressShared
+import WordPressSharedUI
 
 @MainActor
 public protocol StatsRouterScreenFactory: AnyObject {

Modules/Sources/JetpackStatsWidgetsCore/AppIntents/SelectSiteIntent.swift

@@ -1,3 +1,4 @@
+#if os(iOS)
 import AppIntents
 
 /// The widget configuration intent that lets the user pick which site a stats widget shows.
@@ -34,3 +35,4 @@ public struct SelectSiteIntent: WidgetConfigurationIntent, CustomIntentMigratedA
 
     public init() {}
 }
+#endif