Fixes CMM-680: date pickers clipped on Touch ID devives (#24773)

Author: kean

Modules/Sources/JetpackStats/Views/LegacyFloatingDateControl.swift

@@ -19,6 +19,7 @@ struct LegacyFloatingDateControl: View {
             Spacer(minLength: 8)
             navigationControls
         }
+        .modifier(MinimumBottomSafeArea(minPadding: 16))
         .dynamicTypeSize(...DynamicTypeSize.xLarge)
         .padding(.horizontal, 24)
         .background {
@@ -159,6 +160,24 @@ private struct StatsDateRangeTip: Tip {
     }
 }
 
+private struct MinimumBottomSafeArea: ViewModifier {
+    let minPadding: CGFloat
+
+    @State private var bottomInset: CGFloat = 0
+
+    func body(content: Content) -> some View {
+        content
+            .padding(.bottom, bottomInset == 0 ? minPadding : 0)
+            .overlay(
+                GeometryReader { geometry in
+                    Color.clear.onAppear {
+                        self.bottomInset = geometry.safeAreaInsets.bottom
+                    }
+                }
+            )
+    }
+}
+
 private extension View {
     func floatingStyle(cornerRadius: CGFloat = 40) -> some View {
         modifier(FloatingStyle(cornerRadius: cornerRadius))

RELEASE-NOTES.txt

@@ -1,6 +1,7 @@
 26.2
 -----
 * [*] New Stats: Add support for "weeks" granularity [#24767]
+* [*] New Stats: Fix an issue with date controls clipped on Touch ID devices [#24773]
 * [*] New Stats: Fix dark mode support in custom range picker [#24770]
 * [*] New Stats: Fix edit card menu shown in the wrong places [#24774]
 * [*] Fix Split View mode on iPad on some scenarios in portrait mode [#24705]

WordPress/Classes/ViewRelated/Stats/Insights/SiteStatsInsightsTableViewController.swift

@@ -4,9 +4,7 @@ import WordPressKit
 import WordPressFlux
 import WordPressUI
 
-class SiteStatsInsightsTableViewController: SiteStatsBaseTableViewController, StoryboardLoadable {
-    static var defaultStoryboardName: String = "SiteStatsDashboard"
-
+class SiteStatsInsightsTableViewController: SiteStatsBaseTableViewController {
     weak var bannerView: JetpackBannerView?
 
     var isGrowAudienceShowing: Bool {
@@ -54,6 +52,17 @@ class SiteStatsInsightsTableViewController: SiteStatsBaseTableViewController, St
         return ImmuTableDiffableViewHandler(takeOver: self, with: analyticsTracker)
     }()
 
+    // MARK: - Initialization
+
+    init() {
+        super.init(nibName: nil, bundle: nil)
+        tableStyle = .insetGrouped
+    }
+
+    required init?(coder: NSCoder) {
+        fatalError("init(coder:) has not been implemented")
+    }
+
     // MARK: - View
 
     override func viewDidLoad() {

WordPress/Classes/ViewRelated/Stats/Period Stats/SiteStatsPeriodTableViewController.swift

@@ -18,8 +18,6 @@ protocol SiteStatsReferrerDelegate: AnyObject {
 }
 
 final class SiteStatsPeriodTableViewController: SiteStatsBaseTableViewController {
-    static var defaultStoryboardName: String = "SiteStatsDashboard"
-
     weak var bannerView: JetpackBannerView?
 
     // MARK: - Properties