Access local window instead of via UIApplication or UIApplicationDelegate (#25672)

* Dismiss the presented controller via the in-scope presenter

The quick-action handler already holds the shared presenter; use its
rootViewController to dismiss rather than reaching for the app delegate's
window.

* Read the featured image safe-area inset from the view's own window

* Host the appearance-change transition on the settings view's own window

* Read the footer safe-area inset from the view's own window

* Host the milestone confetti on the view's own window

* Block interaction on the connection view's own window during loading

* Resolve the debug menu's host window from its own gesture

* Remove the loading functions in JetpackConnectionViewController

* Remove unused ReaderDetailFeaturedImageView

Author: crazytonyli

WordPress/Classes/System/3D Touch/WP3DTouchShortcutHandler.swift

@@ -29,22 +29,22 @@ open class WP3DTouchShortcutHandler: NSObject {
                 return true
             case ShortcutIdentifier.Stats.type:
                 WPAnalytics.track(.shortcutStats)
-                clearCurrentViewController()
+                clearCurrentViewController(rootViewPresenter.rootViewController)
                 if let mainBlog = Blog.lastUsedOrFirst(in: ContextManager.shared.mainContext) {
                     rootViewPresenter.showStats(for: mainBlog, source: .shortcut)
                 }
                 return true
             case ShortcutIdentifier.Notifications.type:
                 WPAnalytics.track(.shortcutNotifications)
-                clearCurrentViewController()
+                clearCurrentViewController(rootViewPresenter.rootViewController)
                 rootViewPresenter.showNotificationsTab()
                 return true
             default:
                 return false
         }
     }
 
-    fileprivate func clearCurrentViewController() {
-        WordPressAppDelegate.shared?.window?.rootViewController?.dismiss(animated: false)
+    fileprivate func clearCurrentViewController(_ rootViewController: UIViewController) {
+        rootViewController.dismiss(animated: false)
     }
 }

WordPress/Classes/ViewRelated/Gutenberg/Collapsable Header/CollapsableHeaderViewController.swift

@@ -110,7 +110,7 @@ class CollapsableHeaderViewController: UIViewController, NoResultsViewHost {
     private var footerHeight: CGFloat {
         let verticalMargins: CGFloat = 16
         let buttonHeight: CGFloat = 44
-        let safeArea = (UIApplication.shared.mainWindow?.safeAreaInsets.bottom ?? 0)
+        let safeArea = (view.window?.safeAreaInsets.bottom ?? 0)
 
         var height = verticalMargins + buttonHeight + verticalMargins + safeArea
 

WordPress/Classes/ViewRelated/Jetpack/Jetpack Settings/JetpackConnectionViewController.swift

@@ -120,11 +120,19 @@ open class JetpackConnectionViewController: UITableViewController {
 
     @objc func disconnectJetpack() {
         WPAnalytics.trackEvent(.jetpackDisconnectRequested)
-        startLoading()
+
+        // Block user interactions while disconnecting, since navigating away from this view controller
+        // during the process can leave the application in an undetermined state. Capture the window now
+        // so it can be re-enabled even if `view.window` becomes nil after the view controller is dismissed.
+        activityIndicatorView.startAnimating()
+        let window = view.window
+        window?.isUserInteractionEnabled = false
+
         self.service.disconnectJetpackFromBlog(
             self.blog,
             success: { [weak self] in
-                self?.stopLoading()
+                self?.activityIndicatorView.stopAnimating()
+                window?.isUserInteractionEnabled = true
                 if let blog = self?.blog {
                     let service = BlogService(coreDataStack: ContextManager.shared)
                     service.remove(blog)
@@ -134,7 +142,8 @@ open class JetpackConnectionViewController: UITableViewController {
                 }
             },
             failure: { [weak self] error in
-                self?.stopLoading()
+                self?.activityIndicatorView.stopAnimating()
+                window?.isUserInteractionEnabled = true
                 let errorTitle = NSLocalizedString(
                     "Error disconnecting Jetpack",
                     comment: "Title of error dialog when disconnecting jetpack fails."
@@ -157,20 +166,3 @@ open class JetpackConnectionViewController: UITableViewController {
         }
     }
 }
-
-// MARK: - Loading
-
-/// Loading blocks user interactions while loading is in progress since navigating from this view controller
-/// during Jetpack connection or disconnection process can leave the application in an undetermined state.
-///
-private extension JetpackConnectionViewController {
-    func startLoading() {
-        activityIndicatorView.startAnimating()
-        UIApplication.shared.mainWindow?.isUserInteractionEnabled = false
-    }
-
-    func stopLoading() {
-        activityIndicatorView.stopAnimating()
-        UIApplication.shared.mainWindow?.isUserInteractionEnabled = true
-    }
-}

WordPress/Classes/ViewRelated/Me/App Settings/AppSettingsViewController.swift

@@ -297,7 +297,7 @@ class AppSettingsViewController: UITableViewController {
     }
 
     private func overrideAppAppearance(with style: UIUserInterfaceStyle) {
-        let transitionView: UIView = WordPressAppDelegate.shared?.window ?? view
+        let transitionView: UIView = view.window ?? view
         UIView.transition(with: transitionView,
                           duration: 0.3,
                           options: .transitionCrossDissolve,

WordPress/Classes/ViewRelated/Me/App Settings/DebugMenuViewController.swift

@@ -257,13 +257,13 @@ final class DebugMenuViewController: UIHostingController<DebugMenuView> {
 
         assert(window != nil)
 
-        let gesture = UIScreenEdgePanGestureRecognizer(target: DebugMenuViewController.self, action: #selector(showDebugMenu))
+        let gesture = UIScreenEdgePanGestureRecognizer(target: DebugMenuViewController.self, action: #selector(showDebugMenu(_:)))
         gesture.edges = .right
         window?.addGestureRecognizer(gesture)
     }
 
-    @objc private static func showDebugMenu() {
-        guard let window = UIApplication.sharedIfAvailable()?.mainWindow,
+    @objc private static func showDebugMenu(_ sender: UIScreenEdgePanGestureRecognizer) {
+        guard let window = sender.view as? UIWindow,
               let topViewController = window.topmostPresentedViewController,
               !((topViewController as? UINavigationController)?.viewControllers.first is DebugMenuViewController) else {
             return

WordPress/Classes/ViewRelated/Notifications/Controllers/NotificationDetailsViewController.swift

@@ -724,14 +724,14 @@ private extension NotificationDetailsViewController {
     func showConfettiIfNeeded() {
         guard note.isViewMilestone,
               !confettiWasShown,
-              let view = UIApplication.shared.mainWindow,
+              let window = view.window,
               let frame = navigationController?.view.frame else {
             return
         }
         // This method will remove any existing `ConfettiView` before adding a new one
         // This ensures that when we navigate through notifications, if there is an
         // ongoging animation, it will be removed and replaced by a new one
-        ConfettiView.cleanupAndAnimate(on: view, frame: frame) { confettiView in
+        ConfettiView.cleanupAndAnimate(on: window, frame: frame) { confettiView in
 
             // removing this instance when the animation completes, will prevent
             // the animation to suddenly stop if users navigate away from the note