Commit 98e73cd
authored
Remove dead internal app-icon versioning task (#25806)
The `assets:check` Rake task generated a version-stamped internal app icon
via `Scripts/BuildPhases/AddVersionToIcons.sh`, falling back to copying
`AppIcon.appiconset` into `AppIcon-Internal.appiconset` when the script
failed. All three are already gone — the script was deleted and the app
icons moved to `Sources/*/Resources/Assets.xcassets/` (targets use
`AppIconLegacy`) — so the task's skip-guard globbed a path that no longer
exists, ran on every `rake dependencies`, and printed a spurious `cp`
error when the deleted source appiconset wasn't found.
Remove the task, unwire it from `dependencies`, and drop the stale
`.gitignore` entries for the generated internal-icon paths.
ImageMagick, Ghostscript, and RMagick are left in place — they back the
promo-screenshots lane, not this task.1 parent 242e50f commit 98e73cd
2 files changed
Lines changed: 1 addition & 19 deletions
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
60 | 60 | | |
61 | 61 | | |
62 | 62 | | |
63 | | - | |
64 | 63 | | |
65 | 64 | | |
66 | 65 | | |
| |||
86 | 85 | | |
87 | 86 | | |
88 | 87 | | |
89 | | - | |
90 | | - | |
91 | | - | |
92 | | - | |
93 | 88 | | |
94 | 89 | | |
95 | 90 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
14 | 14 | | |
15 | 15 | | |
16 | 16 | | |
17 | | - | |
| 17 | + | |
18 | 18 | | |
19 | 19 | | |
20 | 20 | | |
| |||
100 | 100 | | |
101 | 101 | | |
102 | 102 | | |
103 | | - | |
104 | | - | |
105 | | - | |
106 | | - | |
107 | | - | |
108 | | - | |
109 | | - | |
110 | | - | |
111 | | - | |
112 | | - | |
113 | | - | |
114 | | - | |
115 | | - | |
116 | 103 | | |
117 | 104 | | |
118 | 105 | | |
| |||
0 commit comments