Skip to content

Commit 98e73cd

Browse files
authored
Remove dead internal app-icon versioning task (#25806)
The `assets:check` Rake task generated a version-stamped internal app icon via `Scripts/BuildPhases/AddVersionToIcons.sh`, falling back to copying `AppIcon.appiconset` into `AppIcon-Internal.appiconset` when the script failed. All three are already gone — the script was deleted and the app icons moved to `Sources/*/Resources/Assets.xcassets/` (targets use `AppIconLegacy`) — so the task's skip-guard globbed a path that no longer exists, ran on every `rake dependencies`, and printed a spurious `cp` error when the deleted source appiconset wasn't found. Remove the task, unwire it from `dependencies`, and drop the stale `.gitignore` entries for the generated internal-icon paths. ImageMagick, Ghostscript, and RMagick are left in place — they back the promo-screenshots lane, not this task.
1 parent 242e50f commit 98e73cd

2 files changed

Lines changed: 1 addition & 19 deletions

File tree

.gitignore

Lines changed: 0 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -60,7 +60,6 @@ WordPress/WordPress.xcodeproj/xcuserdata
6060
WordPress/Derived Sources/
6161
# coverage.py
6262
*/CoverageData/*
63-
WordPress/Images.xcassets/AppIcon-Internal.appiconset
6463

6564
# Dependencies
6665
vendor
@@ -86,10 +85,6 @@ Scripts/fastlane/
8685
# CI Artifacts Location
8786
Artifacts
8887

89-
# Generated Internal Icons
90-
WordPress/Resources/AppImages.xcassets/AppIcon-Internal.appiconset
91-
WordPress/Resources/Icons-Internal
92-
9388
# All encrypted secrets should be stored under .configure-files
9489
# Everything without a .enc extension is ignored
9590
.configure-files/*

Rakefile

Lines changed: 1 addition & 14 deletions
Original file line numberDiff line numberDiff line change
@@ -14,7 +14,7 @@ PROJECT_DIR = __dir__
1414
abort('Project directory contains one or more spaces – unable to continue.') if PROJECT_DIR.include?(' ')
1515

1616
desc 'Install required dependencies'
17-
task dependencies: %w[dependencies:check assets:check dependencies:gutenberg_xcframeworks]
17+
task dependencies: %w[dependencies:check dependencies:gutenberg_xcframeworks]
1818

1919
namespace :dependencies do
2020
task check: %w[ruby:check bundler:check bundle:check credentials:apply]
@@ -100,19 +100,6 @@ bundle exec fastlane run configure_apply force:true
100100
end
101101
end
102102

103-
namespace :assets do
104-
task :check do
105-
next unless Dir['WordPress/Resources/AppImages.xcassets/AppIcon-Internal.appiconset/*.png'].empty?
106-
107-
Dir.mktmpdir do |tmpdir|
108-
puts 'Generate internal icon set'
109-
if system("export PROJECT_DIR=#{Dir.pwd}/WordPress && export TEMP_DIR=#{tmpdir} && ./Scripts/BuildPhases/AddVersionToIcons.sh >/dev/null 2>&1") != 0
110-
system("cp #{Dir.pwd}/WordPress/Resources/AppImages.xcassets/AppIcon.appiconset/*.png #{Dir.pwd}/WordPress/Resources/AppImages.xcassets/AppIcon-Internal.appiconset/")
111-
end
112-
end
113-
end
114-
end
115-
116103
CLOBBER << 'vendor'
117104

118105
desc 'Checks the source for style errors. Lints the whole project, or only the given paths: rake lint[path1,path2]'

0 commit comments

Comments
 (0)