Fix more warnings

Author: kean

WordPress/Classes/ViewRelated/Post/PostCompactCell.swift

@@ -142,7 +142,6 @@ class PostCompactCell: UITableViewCell {
         guard let viewModel = viewModel else {
             return
         }
-
         badgesLabel.textColor = viewModel.statusColor
         badgesLabel.text = viewModel.statusAndBadges(separatedBy: Constants.separator)
         if badgesLabel.text?.isEmpty ?? true {
@@ -153,9 +152,6 @@ class PostCompactCell: UITableViewCell {
     }
 
     private func configureMenuInteraction() {
-        guard let viewModel = viewModel else {
-            return
-        }
         menuButton.isEnabled = true
         menuButton.alpha = 1.0
     }

WordPress/Classes/ViewRelated/Reader/Theme/ReaderDisplaySetting.swift

@@ -442,7 +442,7 @@ private extension UIColor {
     - parameter brightnessValue: A number that represents the brightness of a color. It ranges from 0.0 (black) to 1.0 (white).
     - return: YES if brightness is higher than the brightness value provided.
     */
-    public func brighterThan(_ brightnessValue: Double) -> Bool {
+    func brighterThan(_ brightnessValue: Double) -> Bool {
         return Double(YIQBrightness()) / 255 > brightnessValue
     }
 

WordPress/Classes/ViewRelated/Stats/SiteStatsDashboardViewController.swift

@@ -230,7 +230,6 @@ private extension SiteStatsDashboardViewController {
 
     func updatePeriodView(oldSelectedTab: StatsTabType) {
         let selectedPeriodChanged = currentSelectedTab != oldSelectedTab
-        let previousSelectedPeriodWasInsights = oldSelectedTab == .insights
         let pageViewControllerIsEmpty = pageViewController?.viewControllers?.isEmpty ?? true
         let isGrowAudienceShowingOnInsights = insightsTableViewController.isGrowAudienceShowing
 

WordPress/Classes/ViewRelated/System/NetworkAware.swift

@@ -61,11 +61,11 @@ extension NetworkStatusDelegate where Self: UIViewController {
 
     fileprivate var receiver: ReachabilityNotificationObserver? {
         get {
-            return objc_getAssociatedObject(self, &NetworkStatusAssociatedKeys.associatedObjectKey) as? ReachabilityNotificationObserver
+            return objc_getAssociatedObject(self, NetworkStatusAssociatedKeys.associatedObjectKey) as? ReachabilityNotificationObserver
         }
 
         set {
-            objc_setAssociatedObject(self, &NetworkStatusAssociatedKeys.associatedObjectKey, newValue, .OBJC_ASSOCIATION_RETAIN)
+            objc_setAssociatedObject(self, NetworkStatusAssociatedKeys.associatedObjectKey, newValue, .OBJC_ASSOCIATION_RETAIN)
         }
     }
 }
@@ -80,17 +80,17 @@ extension NetworkStatusDelegate where Self: NetworkStatusReceiver {
 
     fileprivate var receiver: ReachabilityNotificationObserver? {
         get {
-            return objc_getAssociatedObject(self, &NetworkStatusAssociatedKeys.associatedObjectKey) as? ReachabilityNotificationObserver
+            return objc_getAssociatedObject(self, NetworkStatusAssociatedKeys.associatedObjectKey) as? ReachabilityNotificationObserver
         }
 
         set {
-            objc_setAssociatedObject(self, &NetworkStatusAssociatedKeys.associatedObjectKey, newValue, .OBJC_ASSOCIATION_RETAIN)
+            objc_setAssociatedObject(self, NetworkStatusAssociatedKeys.associatedObjectKey, newValue, .OBJC_ASSOCIATION_RETAIN)
         }
     }
 }
 
 fileprivate struct NetworkStatusAssociatedKeys {
-    static var associatedObjectKey = "org.wordpress.networkstatus.notificationreceiver"
+    static let associatedObjectKey = malloc(1)!
 }
 
 fileprivate final class ReachabilityNotificationObserver: NSObject {