Run xcstringstool via Open3 so the catalog scan output stays clean

fastlane's sh treats each call as an action: even with log: false it prints a
'--- Step: shell command ---' banner per call and lists it in the run summary. extract is
chunked into ~7 calls and sync runs twice, so that wrapped the real progress in a wall of
banners. Run xcstringstool through Open3.capture2e instead (argv — safe for paths with spaces;
captured output surfaced only on failure), via a run_xcstringstool helper. The scan now prints
just its own progress lines.

Author: jkmassel

fastlane/lanes/localization_catalog.rb

@@ -3,6 +3,7 @@
 require 'json'
 require 'tmpdir'
 require 'fileutils'
+require 'open3'
 require_relative 'catalog_helper'
 require_relative 'catalog_strings_helper'
 
@@ -156,6 +157,15 @@ def catalog_excluded?(path)
       File.basename(path) == 'AppLocalizedString.swift'
   end
 
+  # Run `xcstringstool <args>` quietly via argv (no shell, so source paths with spaces are safe), capturing
+  # output and surfacing it only on failure. Used instead of fastlane's `sh` for these bulk calls: each passes
+  # hundreds of file paths (or a `--stringsdata` pair per file), so `sh` would echo a massive command line AND
+  # print a "Step: shell command" banner per call. Open3 keeps the run silent and banner-free.
+  def run_xcstringstool(*args)
+    output, status = Open3.capture2e('xcrun', 'xcstringstool', *args)
+    UI.user_error!("xcstringstool #{args.first} failed:\n#{output}") unless status.success?
+  end
+
   # xcstringstool extract -> one .stringsdata per source file (basename-disambiguated). Chunked to stay under
   # the OS argument limit; each chunk gets its own output subdir (see below), which sync then consumes together.
   # `--SwiftUI-Text` (extract `Text("literal")`) is OFF by default and gated behind `swiftui:`. The app has
@@ -179,8 +189,7 @@ def extract_stringsdata(files:, output_dir:, swiftui: false)
       chunk_dir = File.join(output_dir, "chunk-#{index}")
       FileUtils.mkdir_p(chunk_dir)
       UI.message("Extracting strings… (batch #{index + 1}/#{batches.size})")
-      # log: false — each command lists up to 400 file paths; echoing them buries the output.
-      sh('xcrun', 'xcstringstool', 'extract', *chunk, *flags, '--output-directory', chunk_dir, log: false)
+      run_xcstringstool('extract', *chunk, *flags, '--output-directory', chunk_dir)
     end
   end
 
@@ -198,8 +207,7 @@ def sync_localizable_catalog(stringsdata_dir:)
     UI.user_error!('xcstringstool produced no .stringsdata') if stringsdata.empty?
 
     UI.message("Syncing #{stringsdata.count} extracted file(s) into #{File.basename(LOCALIZABLE_CATALOG)}…")
-    # log: false — the command passes a `--stringsdata <path>` pair per file (thousands of args).
-    sh('xcrun', 'xcstringstool', 'sync', LOCALIZABLE_CATALOG, *stringsdata.flat_map { |f| ['--stringsdata', f] }, log: false)
+    run_xcstringstool('sync', LOCALIZABLE_CATALOG, *stringsdata.flat_map { |f| ['--stringsdata', f] })
     JSON.parse(File.read(LOCALIZABLE_CATALOG))['strings'].count
   end
 
@@ -234,7 +242,7 @@ def current_english_values(stringsdata_dir)
       fresh = File.join(tmp, 'Localizable.xcstrings')
       File.write(fresh, "#{JSON.pretty_generate('sourceLanguage' => 'en', 'strings' => {}, 'version' => '1.0')}\n")
       stringsdata = stringsdata_files(stringsdata_dir)
-      sh('xcrun', 'xcstringstool', 'sync', fresh, *stringsdata.flat_map { |f| ['--stringsdata', f] }, log: false)
+      run_xcstringstool('sync', fresh, *stringsdata.flat_map { |f| ['--stringsdata', f] })
       english_values(JSON.parse(File.read(fresh)))
     end
   end