Skip to content

Commit b9109ee

Browse files
committed
Update Dangerfile after PR feedback
1 parent 05e7678 commit b9109ee

1 file changed

Lines changed: 8 additions & 5 deletions

File tree

Dangerfile

Lines changed: 8 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -12,7 +12,7 @@ podfile_checker.check_podfile_does_not_have_branch_references
1212
ios_release_checker.check_core_data_model_changed
1313
ios_release_checker.check_release_notes_and_app_store_strings
1414

15-
# skip remaining checks if we're during the release process
15+
# skip remaining checks if we're in a release-process PR
1616
if github.pr_labels.include?('Releases')
1717
message('This PR has the `Releases` label: some checks will be skipped.')
1818
return
@@ -26,14 +26,17 @@ view_changes_checker.check
2626

2727
pr_size_checker.check_diff_size(max_size: 500)
2828

29-
# skip remaining checks if we have a Draft PR
30-
return if github.pr_draft?
29+
# skip remaining checks if the PR is still a Draft
30+
if github.pr_draft?
31+
message('This PR is still a Draft: some checks will be skipped.')
32+
return
33+
end
3134

3235
labels_checker.check(
3336
do_not_merge_labels: ['[Status] DO NOT MERGE'],
3437
required_labels: [//],
3538
required_labels_error: 'PR requires at least one label.'
3639
)
3740

38-
# skip check for WIP features unless the PR is against the main branch or release branch
39-
milestone_checker.check_milestone_due_date(days_before_due: 4) unless github_utils.wip_feature? && !(github_utils.release_branch? || github_utils.main_branch?)
41+
# runs the milestone check if this is not a WIP feature and the PR is against the main branch or the release branch
42+
milestone_checker.check_milestone_due_date(days_before_due: 4) if (github_utils.main_branch? || github_utils.release_branch?) && !github_utils.wip_feature?

0 commit comments

Comments
 (0)