Refactor: update blog detail header view on domain credit redemption success

Author: Momo Ozawa

WordPress/Classes/ViewRelated/Blog/Blog Details/BlogDetailsViewController+DomainCredit.swift

@@ -33,7 +33,15 @@ extension BlogDetailsViewController {
     private func presentDomainCreditRedemptionSuccess(domain: String) {
         let controller = DomainCreditRedemptionSuccessViewController(domain: domain, delegate: self)
         present(controller, animated: true) { [weak self] in
-            self?.updateTableViewAndHeader()
+            self?.updateTableView {
+                guard
+                    let parent = self?.parent as? MySiteViewController,
+                    let blog = self?.blog
+                else {
+                    return
+                }
+                parent.sitePickerViewController?.blogDetailHeaderView.blog = blog
+            }
         }
     }
 }

WordPress/Classes/ViewRelated/Blog/Blog Details/BlogDetailsViewController.h

@@ -153,7 +153,7 @@ typedef NS_ENUM(NSUInteger, BlogDetailsNavigationSource) {
 - (void)showPageListFromSource:(BlogDetailsNavigationSource)source;
 - (void)showMediaLibraryFromSource:(BlogDetailsNavigationSource)source;
 - (void)showStatsFromSource:(BlogDetailsNavigationSource)source;
-- (void)updateTableViewAndHeader;
+- (void)updateTableView:(nullable void(^)(void))completion;
 - (void)preloadMetadata;
 - (void)pulledToRefreshWith:(nonnull UIRefreshControl *)refreshControl  onCompletion:(nullable void(^)(void))completion;
 @end

WordPress/Classes/ViewRelated/Blog/Blog Details/BlogDetailsViewController.m

@@ -1711,20 +1711,20 @@ - (UIPresentationController *)presentationControllerForPresentedViewController:(
 
 - (void)updateTableViewAndHeader
 {
-    [self updateTableViewAndHeader:^{}];
+    [self updateTableView:^{}];
 }
 
-/// This method syncs the blog and its metadata, then reloads the table view and updates the header with the synced blog.
+/// This method syncs the blog and its metadata, then reloads the table view.
 ///
-- (void)updateTableViewAndHeader:(void(^)(void))onComplete
+- (void)updateTableView:(void(^)(void))completion
 {
     __weak __typeof(self) weakSelf = self;
     [self.blogService syncBlogAndAllMetadata:self.blog
                            completionHandler:
      ^{
         [weakSelf configureTableViewData];
         [weakSelf reloadTableViewPreservingSelection];
-        onComplete();
+        completion();
     }];
 }
 
@@ -1735,7 +1735,7 @@ - (void)pulledToRefresh {
 
 - (void)pulledToRefreshWith:(UIRefreshControl *)refreshControl onCompletion:( void(^)(void))completion {
 
-    [self updateTableViewAndHeader: ^{
+    [self updateTableView: ^{
         // WORKAROUND: if we don't dispatch this asynchronously, the refresh end animation is clunky.
         // To recognize if we can remove this, simply remove the dispatch_async call and test pulling
         // down to refresh the site.