Improve nil-safety in BooleanUserDefaultsDebugView

justtwago · justtwago · commit db630b2d713c · 2024-01-31T12:15:34.000-07:00
diff --git a/WordPress/Classes/ViewRelated/Me/App Settings/Boolean User Defaults/BooleanUserDefaultsDebugView.swift b/WordPress/Classes/ViewRelated/Me/App Settings/Boolean User Defaults/BooleanUserDefaultsDebugView.swift
@@ -15,7 +15,7 @@ struct BooleanUserDefaultsDebugView: View {
                                 get: { userDefaultsSection[userDefaultKey]?.value ?? false },
                                 set: { newValue in viewModel.updateUserDefault(newValue, forSection: sectionKey, forUserDefault: userDefaultKey) }
                             )
-                            Toggle(userDefaultsSection[userDefaultKey]!.title, isOn: isOn)
+                            Toggle(userDefaultsSection[userDefaultKey]?.title ?? Strings.unrecognizedEntryTitle, isOn: isOn)
                                 .font(.caption)
                                 .toggleStyle(
                                     SwitchToggleStyle(
@@ -34,4 +34,6 @@ struct BooleanUserDefaultsDebugView: View {
 
 private enum Strings {
     static let title = NSLocalizedString("debugMenu.booleanUserDefaults.title", value: "Boolean User Defaults", comment: "Boolean User Defaults Debug Menu screen title")
+
+    static let unrecognizedEntryTitle = "Unrecognized Entry"
 }

Original file line number	Diff line number	Diff line change
`@@ -15,7 +15,7 @@ struct BooleanUserDefaultsDebugView: View {`
`15`	`15`	`get: { userDefaultsSection[userDefaultKey]?.value ?? false },`
`16`	`16`	`set: { newValue in viewModel.updateUserDefault(newValue, forSection: sectionKey, forUserDefault: userDefaultKey) }`
`17`	`17`	`)`
`18`		`- Toggle(userDefaultsSection[userDefaultKey]!.title, isOn: isOn)`
	`18`	`+ Toggle(userDefaultsSection[userDefaultKey]?.title ?? Strings.unrecognizedEntryTitle, isOn: isOn)`
`19`	`19`	`.font(.caption)`
`20`	`20`	`.toggleStyle(`
`21`	`21`	`SwitchToggleStyle(`
`@@ -34,4 +34,6 @@ struct BooleanUserDefaultsDebugView: View {`
`34`	`34`
`35`	`35`	`private enum Strings {`
`36`	`36`	`static let title = NSLocalizedString("debugMenu.booleanUserDefaults.title", value: "Boolean User Defaults", comment: "Boolean User Defaults Debug Menu screen title")`
	`37`	`+`
	`38`	`+ static let unrecognizedEntryTitle = "Unrecognized Entry"`
`37`	`39`	`}`