Skip to content

Commit dfc25f3

Browse files
authored
Fix the loading sites UI in the share extensions (#25798)
* Format share extension site picker * Show site fetch states inline in share extension * Add a release note
1 parent f93607a commit dfc25f3

3 files changed

Lines changed: 405 additions & 131 deletions

File tree

Modules/Sources/WordPressUI/Deprecated/NoResultsViewController.swift

Lines changed: 14 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -174,6 +174,20 @@ import WordPressShared
174174
displayTitleViewOnly = false
175175
}
176176

177+
/// Configures the view for an in-progress operation without replacing it with the no-connection presentation.
178+
public func configureForLoading(title: String) {
179+
titleText = title
180+
subtitleText = nil
181+
attributedSubtitleText = nil
182+
configureAttributedSubtitle = nil
183+
attributedTitleText = nil
184+
buttonText = nil
185+
imageName = nil
186+
subtitleImageName = nil
187+
accessorySubview = Self.loadingAccessoryView()
188+
displayTitleViewOnly = false
189+
}
190+
177191
/// Public method to show the title specifically formatted for no search results.
178192
/// When the view is configured, it will display just a label with specific constraints.
179193
///

RELEASE-NOTES.txt

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -5,6 +5,7 @@
55
* [*] [build tooling] Add a String Catalog localization pipeline (plurals + build-free catalog generation) with a CI coverage gate [#25688]
66
* [*] [internal] Stats widgets: migrate the site picker from SiriKit to App Intents [#25753]
77
* [*] Fix Blogging Reminders text color in dark mode [#25780]
8+
* [*] Share extensions: Fix the site picker showing an error while sites are still loading [#25798]
89

910
27.0
1011
-----

0 commit comments

Comments
 (0)