Create a XCTestCase subclass to DRY managing CoreDataStack mock (#18578)

Create a XCTestCase subclass to manage CoreDataStack mock implementation

Author: mokagio

WordPress/WordPress.xcodeproj/project.pbxproj

@@ -933,6 +933,7 @@
 		46F584B92624E6380010A723 /* BlockEditorSettings+GutenbergEditorSettings.swift in Sources */ = {isa = PBXBuildFile; fileRef = 46F584B72624E6380010A723 /* BlockEditorSettings+GutenbergEditorSettings.swift */; };
 		46F58501262605930010A723 /* BlockEditorSettingsServiceTests.swift in Sources */ = {isa = PBXBuildFile; fileRef = 46F58500262605930010A723 /* BlockEditorSettingsServiceTests.swift */; };
 		4A17C1A4281A823E0001FFE5 /* NSManagedObject+Fixture.swift in Sources */ = {isa = PBXBuildFile; fileRef = 4A17C1A3281A823E0001FFE5 /* NSManagedObject+Fixture.swift */; };
+		4A266B91282B13A70089CF3D /* CoreDataTestCase.swift in Sources */ = {isa = PBXBuildFile; fileRef = 4A266B90282B13A70089CF3D /* CoreDataTestCase.swift */; };
 		4A266B8F282B05210089CF3D /* JSONObjectTests.swift in Sources */ = {isa = PBXBuildFile; fileRef = 4A266B8E282B05210089CF3D /* JSONObjectTests.swift */; };
 		4B2DD0F29CD6AC353C056D41 /* Pods_WordPressUITests.framework in Frameworks */ = {isa = PBXBuildFile; fileRef = 8DCE7542239FBC709B90EA85 /* Pods_WordPressUITests.framework */; };
 		4C8A715EBCE7E73AEE216293 /* Pods_WordPressShareExtension.framework in Frameworks */ = {isa = PBXBuildFile; fileRef = F47DB4A8EC2E6844E213A3FA /* Pods_WordPressShareExtension.framework */; };
@@ -5735,6 +5736,7 @@
 		46F58500262605930010A723 /* BlockEditorSettingsServiceTests.swift */ = {isa = PBXFileReference; lastKnownFileType = sourcecode.swift; path = BlockEditorSettingsServiceTests.swift; sourceTree = "<group>"; };
 		46F84612185A8B7E009D0DA5 /* PostContentProvider.h */ = {isa = PBXFileReference; fileEncoding = 4; lastKnownFileType = sourcecode.c.h; path = PostContentProvider.h; sourceTree = "<group>"; };
 		4A17C1A3281A823E0001FFE5 /* NSManagedObject+Fixture.swift */ = {isa = PBXFileReference; lastKnownFileType = sourcecode.swift; path = "NSManagedObject+Fixture.swift"; sourceTree = "<group>"; };
+		4A266B90282B13A70089CF3D /* CoreDataTestCase.swift */ = {isa = PBXFileReference; lastKnownFileType = sourcecode.swift; path = CoreDataTestCase.swift; sourceTree = "<group>"; };
 		4A266B8E282B05210089CF3D /* JSONObjectTests.swift */ = {isa = PBXFileReference; lastKnownFileType = sourcecode.swift; path = JSONObjectTests.swift; sourceTree = "<group>"; };
 		4D520D4E22972BC9002F5924 /* acknowledgements.html */ = {isa = PBXFileReference; fileEncoding = 4; lastKnownFileType = text.html; name = acknowledgements.html; path = "../Pods/Target Support Files/Pods-Apps-WordPress/acknowledgements.html"; sourceTree = "<group>"; };
 		51A5F017948878F7E26979A0 /* Pods-Apps-WordPress.release.xcconfig */ = {isa = PBXFileReference; includeInIndex = 1; lastKnownFileType = text.xcconfig; name = "Pods-Apps-WordPress.release.xcconfig"; path = "../Pods/Target Support Files/Pods-Apps-WordPress/Pods-Apps-WordPress.release.xcconfig"; sourceTree = "<group>"; };
@@ -11440,6 +11442,7 @@
 				FAE8EE9B273AD0A800A65307 /* QuickStartSettingsTests.swift */,
 				179501CC27A01D4100882787 /* PublicizeAuthorizationURLComponentsTests.swift */,
 				80EF92922810FA5A0064A971 /* QuickStartFactoryTests.swift */,
+				4A266B90282B13A70089CF3D /* CoreDataTestCase.swift */,
 				4A266B8E282B05210089CF3D /* JSONObjectTests.swift */,
 			);
 			name = Utility;
@@ -19825,6 +19828,7 @@
 				8BC12F72231FEBA1004DDA72 /* PostCoordinatorTests.swift in Sources */,
 				D8B6BEB7203E11F2007C8A19 /* Bundle+LoadFromNib.swift in Sources */,
 				8B2D4F5527ECE376009B085C /* BlogDashboardPostsParserTests.swift in Sources */,
+				4A266B91282B13A70089CF3D /* CoreDataTestCase.swift in Sources */,
 				24B1AE3124FEC79900B9F334 /* RemoteFeatureFlagTests.swift in Sources */,
 				E135965D1E7152D1006C6606 /* RecentSitesServiceTests.swift in Sources */,
 				D88A64AC208D9B09008AE9BC /* StockPhotosPageableTests.swift in Sources */,

WordPress/WordPressTest/Analytics/EditorAnalytics/PostEditorAnalyticsSessionTests.swift

@@ -1,7 +1,7 @@
 import Foundation
 @testable import WordPress
 
-class PostEditorAnalyticsSessionTests: XCTestCase {
+class PostEditorAnalyticsSessionTests: CoreDataTestCase {
     enum PostContent {
         static let classic = """
         Text <strong>bold</strong> <em>italic</em>
@@ -14,14 +14,11 @@ class PostEditorAnalyticsSessionTests: XCTestCase {
         """
     }
 
-    private var contextManager: ContextManagerMock!
     private var context: NSManagedObjectContext!
 
-
     override func setUp() {
-        contextManager = ContextManagerMock()
         context = NSManagedObjectContext(concurrencyType: .mainQueueConcurrencyType)
-        context.parent = contextManager.mainContext
+        context.parent = mainContext
         TestAnalyticsTracker.setup()
     }
 

WordPress/WordPressTest/Aztec/AztecPostViewControllerAttachmentTests.swift

@@ -4,22 +4,19 @@ import Aztec
 import WordPressEditor
 import Nimble
 
-class AztecPostViewControllerAttachmentTests: XCTestCase {
+class AztecPostViewControllerAttachmentTests: CoreDataTestCase {
 
-    private var contextManager: ContextManagerMock!
     private var context: NSManagedObjectContext!
 
     override func setUp() {
         super.setUp()
 
-        contextManager = ContextManagerMock()
         context = contextManager.newDerivedContext()
     }
 
     override func tearDown() {
         super.tearDown()
         context = nil
-        contextManager = nil
     }
 
     func testMediaUploadErrorsWillShowAnErrorMessageAndOverlay() {

WordPress/WordPressTest/CoreDataTestCase.swift

@@ -0,0 +1,15 @@
+import XCTest
+
+/// A `XCTestCase` subclass which manages a mock implementation of `CoreDataStack`. Inherit
+/// from this class to use the `CoreDataStack` mock instance in your test case.
+class CoreDataTestCase: XCTestCase {
+
+    private(set) lazy var contextManager: ContextManagerMock = {
+        ContextManagerMock()
+    }()
+
+    var mainContext: NSManagedObjectContext {
+        return contextManager.mainContext
+    }
+
+}

WordPress/WordPressTest/Dashboard/DashboardCardTests.swift

@@ -9,16 +9,14 @@ class MockDefaultSectionProvider: DefaultSectionProvider {
     }
 }
 
-class ZDashboardCardTests: XCTestCase {
+class ZDashboardCardTests: CoreDataTestCase {
 
-    private var contextManager: ContextManagerMock!
     private var context: NSManagedObjectContext!
     private var blog: Blog!
 
     override func setUp() {
         super.setUp()
 
-        contextManager = ContextManagerMock()
         contextManager.setUpAsSharedInstance()
         context = contextManager.newDerivedContext()
         blog = BlogBuilder(context).build()
@@ -28,7 +26,6 @@ class ZDashboardCardTests: XCTestCase {
         QuickStartTourGuide.shared.remove(from: blog)
         context = nil
         contextManager.tearDown()
-        contextManager = nil
         blog = nil
         super.tearDown()
     }

WordPress/WordPressTest/MarkAsSpamActionTests.swift

@@ -1,7 +1,7 @@
 import XCTest
 @testable import WordPress
 
-final class MarkAsSpamActionTests: XCTestCase {
+final class MarkAsSpamActionTests: CoreDataTestCase {
     private class TestableMarkAsSpam: MarkAsSpam {
         let service: MockNotificationActionsService
 
@@ -23,7 +23,6 @@ final class MarkAsSpamActionTests: XCTestCase {
 
     private var action: MarkAsSpam?
     let utility = NotificationUtility()
-    private var testContextManager: ContextManagerMock!
 
     private struct Constants {
         static let initialStatus: Bool = false
@@ -32,8 +31,7 @@ final class MarkAsSpamActionTests: XCTestCase {
     override func setUp() {
         super.setUp()
         utility.setUp()
-        testContextManager = ContextManagerMock()
-        action = TestableMarkAsSpam(on: Constants.initialStatus, coreDataStack: testContextManager)
+        action = TestableMarkAsSpam(on: Constants.initialStatus, coreDataStack: contextManager)
         makeNetworkAvailable()
     }
 

WordPress/WordPressTest/StatsTestCase.swift

@@ -3,17 +3,7 @@ import CoreData
 @testable import WordPress
 
 // A thin wrapper round XCTestCase for Stats test to avoid repeating boilerplate.
-class StatsTestCase: XCTestCase {
-
-    fileprivate var manager: ContextManagerMock!
-
-    override func setUp() {
-        manager = ContextManagerMock()
-    }
-
-    var mainContext: NSManagedObjectContext {
-        return manager.mainContext
-    }
+class StatsTestCase: CoreDataTestCase {
 
     @discardableResult func createStatsRecord(in context: NSManagedObjectContext,
                                               type: StatsRecordType,