Avoid reloading user defaults sections on toggle switch (#22534)

Author: Artyom Vlasov

WordPress/Classes/ViewRelated/Me/App Settings/Boolean User Defaults/BooleanUserDefaultsDebugView.swift

@@ -5,19 +5,19 @@ struct BooleanUserDefaultsDebugView: View {
 
     var body: some View {
         List {
-            ForEach(viewModel.userDefaultsSections, id: \.key) { section in
+            ForEach(viewModel.userDefaultsSections) { section in
                 Section(header: Text(section.key)
                     .font(.caption)) {
-                        ForEach(section.rows, id: \.key) { row in
+                        ForEach(section.rows) { row in
                             let isOn = Binding<Bool>(
                                 get: {
                                     row.value
                                 },
                                 set: { newValue in
                                     viewModel.updateUserDefault(
                                         newValue,
-                                        forSection: section.key,
-                                        forRow: row.key
+                                        section: section,
+                                        row: row
                                     )
                                 }
                             )

WordPress/Classes/ViewRelated/Me/App Settings/Boolean User Defaults/BooleanUserDefaultsDebugViewModel.swift

@@ -91,39 +91,16 @@ final class BooleanUserDefaultsDebugViewModel: ObservableObject {
         return try? Blog.lookup(withID: Int(id) ?? 0, in: coreDataStack.mainContext)
     }
 
-    func updateUserDefault(_ newValue: Bool, forSection targetSection: String, forRow targetRow: String) {
-        updateAllUserDefaultsSections(newValue, forSection: targetSection, forRow: targetRow)
-        if targetSection == Strings.otherBooleanUserDefaultsSectionID {
-            persistentRepository.set(newValue, forKey: targetRow)
+    func updateUserDefault(_ newValue: Bool, section: Section, row: Row) {
+        row.value = newValue
+
+        if section.key == Strings.otherBooleanUserDefaultsSectionID {
+            persistentRepository.set(newValue, forKey: row.key)
         } else {
-            guard let section = allUserDefaultsSections.first(where: { $0.key == targetSection }) else {
-                return
-            }
             let entries = section.rows.reduce(into: [String: Bool]()) { result, row in
-                if row.key == targetRow {
-                    result[row.key] = newValue
-                } else {
-                    result[row.key] = row.value
-                }
-            }
-            persistentRepository.set(entries, forKey: targetSection)
-        }
-    }
-
-    func updateAllUserDefaultsSections(_ newValue: Bool, forSection targetSection: String, forRow targetRow: String) {
-        allUserDefaultsSections = allUserDefaultsSections.map { currentSection in
-            if currentSection.key == targetSection {
-                let updatedRows = currentSection.rows.map { currentRow in
-                    if currentRow.key == targetRow {
-                        return Row(key: currentRow.key, title: currentRow.title, value: newValue)
-                    } else {
-                        return currentRow
-                    }
-                }
-                return Section(key: currentSection.key, rows: updatedRows)
-            } else {
-                return currentSection
+                result[row.key] = row.value
             }
+            persistentRepository.set(entries, forKey: section.key)
         }
     }
 
@@ -137,15 +114,18 @@ final class BooleanUserDefaultsDebugViewModel: ObservableObject {
 
     // MARK: - Types
 
-    struct Section {
+    struct Section: Identifiable {
+        let id: String = UUID().uuidString
         let key: String
         let rows: [Row]
     }
 
-    final class Row {
+    final class Row: Identifiable {
+        let id: String = UUID().uuidString
         let key: String
         let title: String
-        let value: Bool
+
+        fileprivate(set) var value: Bool
 
         init(key: String, title: String, value: Bool) {
             self.key = key

WordPress/WordPressTest/Me/App Settings/Boolean User Defaults/BooleanUserDefaultsDebugViewModelTests.swift

@@ -128,7 +128,9 @@ class BooleanUserDefaultsDebugViewModelTests: CoreDataTestCase {
         viewModel.load()
 
         // When
-        viewModel.updateUserDefault(false, forSection: "Other", forRow: "entry1")
+        let section = viewModel.userDefaultsSections[0]
+        let row = section.rows[0]
+        viewModel.updateUserDefault(false, section: section, row: row)
 
         // Then
         XCTAssertTrue(viewModel.userDefaultsSections.count == 1)
@@ -145,7 +147,9 @@ class BooleanUserDefaultsDebugViewModelTests: CoreDataTestCase {
         viewModel.load()
 
         // When
-        viewModel.updateUserDefault(false, forSection: "section1", forRow: "entry1")
+        let section = viewModel.userDefaultsSections[0]
+        let row = section.rows[0]
+        viewModel.updateUserDefault(false, section: section, row: row)
 
         // Then
         XCTAssertTrue(viewModel.userDefaultsSections.count == 1)