Fix Xcode warnings (#24781)

Author: kean

Sources/WordPressData/Objective-C/include/Blog.h

@@ -229,7 +229,6 @@ typedef NS_ENUM(NSInteger, SiteVisibility) {
 // wp.koke.me
 @property (weak, readonly, nullable) NSString *hostname;
 
-@property (weak, readonly, nullable) NSString *defaultPostFormatText;
 // Used to check if the blog has an icon set up
 @property (readonly) BOOL hasIcon;
 

Sources/WordPressData/Swift/Post.swift

@@ -77,9 +77,7 @@ public class Post: AbstractPost {
 
         for categoryName in categoryNames {
 
-            assert(blog.categories is Set<PostCategory>)
-            guard let blogCategories = blog.categories as? Set<PostCategory> else {
-                DDLogError("Expected blog.categories to be \(String(describing: Set<PostCategory>.self)).")
+            guard let blogCategories = blog.categories else {
                 return
             }
 

WordPress/Classes/Utility/Blogging Reminders/BloggingRemindersStore.swift

@@ -77,7 +77,6 @@ class BloggingRemindersStore {
             self.init(fileManager: fileManager, configuration: configuration, dataFileURL: url)
         } catch {
             throw Error.configurationDecodingFailed(error: error)
-            self.init(fileManager: fileManager, configuration: [:], dataFileURL: url)
         }
     }
 

WordPress/Classes/ViewRelated/Blog/Blog Dashboard/Cards/DashboardJetpackSocialCardCell.swift

@@ -269,7 +269,7 @@ private extension DashboardJetpackSocialCardCell {
     static func showNoSharesView(for blog: Blog) -> Bool {
         guard let sharingLimit = blog.sharingLimit,
               let dotComID = blog.dotComID?.stringValue,
-              let connections = blog.connections as? Set<PublicizeConnection> else {
+              let connections = blog.connections else {
             return false
         }
         let repository = UserPersistentStoreFactory.instance()

WordPress/Classes/ViewRelated/People/Controllers/PersonViewController.swift

@@ -157,7 +157,7 @@ final class PersonViewController: UITableViewController {
             return
         }
 
-        roleViewController.roles = blog.sortedRoles.map({ $0.toUnmanaged() }) ?? []
+        roleViewController.roles = blog.sortedRoles.map({ $0.toUnmanaged() })
         roleViewController.selectedRole = person.role
         roleViewController.onChange = { [weak self] newRole in
             self?.updateUserRole(newRole)