Skip to content

Commit e313c69

Browse files
committed
changed shouldDisableLongVideos and asset exceedAllowance conditions to re-use encapsulated blog.canUploadAsset function
1 parent 375a7ce commit e313c69

1 file changed

Lines changed: 6 additions & 8 deletions

File tree

WordPress/Classes/Services/Stories/WPMediaPicker+MediaPicker.swift

Lines changed: 6 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -52,7 +52,7 @@ class WPMediaPickerForKanvas: WPNavigationMediaPickerViewController, MediaPicker
5252

5353
let mediaPickerDelegate = MediaPickerDelegate(kanvasDelegate: delegate,
5454
presenter: tabBar,
55-
shouldDisableLongVideos: !blog.hasPaidPlan)
55+
blog: blog)
5656
let options = WPMediaPickerOptions()
5757
options.allowCaptureOfMedia = false
5858

@@ -85,17 +85,15 @@ class MediaPickerDelegate: NSObject, WPMediaPickerViewControllerDelegate {
8585

8686
private weak var kanvasDelegate: KanvasMediaPickerViewControllerDelegate?
8787
private weak var presenter: UIViewController?
88-
89-
private let shouldDisableLongVideos: Bool
90-
88+
private let blog: Blog
9189
private var cancellables = Set<AnyCancellable>()
9290

9391
init(kanvasDelegate: KanvasMediaPickerViewControllerDelegate,
9492
presenter: UIViewController,
95-
shouldDisableLongVideos: Bool = false) {
93+
blog: Blog) {
9694
self.kanvasDelegate = kanvasDelegate
9795
self.presenter = presenter
98-
self.shouldDisableLongVideos = shouldDisableLongVideos
96+
self.blog = blog
9997
}
10098

10199
func mediaPickerControllerDidCancel(_ picker: WPMediaPickerViewController) {
@@ -175,7 +173,7 @@ class MediaPickerDelegate: NSObject, WPMediaPickerViewControllerDelegate {
175173
}
176174

177175
func mediaPickerController(_ picker: WPMediaPickerViewController, shouldShowOverlayViewForCellFor asset: WPMediaAsset) -> Bool {
178-
picker != self && asset.exceedsFreeSitesAllowance() && shouldDisableLongVideos
176+
picker != self && !blog.canUploadAsset(asset)
179177
}
180178

181179
func mediaPickerControllerShouldShowCustomHeaderView(_ picker: WPMediaPickerViewController) -> Bool {
@@ -209,7 +207,7 @@ class MediaPickerDelegate: NSObject, WPMediaPickerViewControllerDelegate {
209207
}
210208

211209
func mediaPickerController(_ picker: WPMediaPickerViewController, shouldSelect asset: WPMediaAsset) -> Bool {
212-
if picker != self, asset.exceedsFreeSitesAllowance(), shouldDisableLongVideos {
210+
if picker != self, !blog.canUploadAsset(asset) {
213211
presentVideoLimitExceededFromPicker(on: picker)
214212
return false
215213
}

0 commit comments

Comments
 (0)