Report keychain failures during AppKeychain and SharedKeychain access

[crazytonyli]

Both keychain wrappers now route every read, write, and delete failure through a shared reporter. The expected not-found stays silent, other real failures are logged via swift-log together with the failing call site, and an entitlement mismatch crashes because it means the access group is unreachable for the entire build rather than a recoverable runtime condition. This adds a swift-log dependency to the WordPressShared target.

[dangermattic]

1 Warning

⚠️

Modules/Package.swift was changed without updating its corresponding Package.resolved. If the change includes adding, removing, or editing a dependency please resolve the Swift packages as appropriate to your project setup (e.g. in Xcode or by running swift package resolve). If the change to the Package.swift did not modify dependencies, ignoring this warning should be safe, but we recommend double checking and running the package resolution just in case. .

Generated by 🚫 Danger

[wpmobilebot]

📲 You can test the changes from this Pull Request in WordPress by scanning the QR code below to install the corresponding build.

	App Name	WordPress
	Configuration	Release-Alpha
	Build Number	32846
	Version	PR #25702
	Bundle ID	org.wordpress.alpha
	Commit	59b3d12
	Installation URL	02v1g82s7uob8

Automatticians: You can use our internal self-serve MC tool to give yourself access to those builds if needed.

[wpmobilebot]

📲 You can test the changes from this Pull Request in Jetpack by scanning the QR code below to install the corresponding build.

	App Name	Jetpack
	Configuration	Release-Alpha
	Build Number	32846
	Version	PR #25702
	Bundle ID	com.jetpack.alpha
	Commit	59b3d12
	Installation URL	4n3rde5269k9o

Automatticians: You can use our internal self-serve MC tool to give yourself access to those builds if needed.

[jkmassel]

This looks generally correct, though I wonder if we can collapse a bunch of the repeated do/catch statements?

[crazytonyli]

I wonder if we can collapse a bunch of the repeated do/catch statements?

The AppKeychain and SharedKeychain implementations are very similar. At their core, they are doing the same things: reading and writing keychain from a given access group. AppKeychain has to do a little bit of extra work, due to the legacy issue of using the same access group between two apps. I intentionally did not reuse much code between them, for the sake of readability.