Fix the loading sites UI in the share extensions#25798
Merged
crazytonyli merged 3 commits intoJul 19, 2026
Merged
Conversation
Collaborator
Generated by 🚫 Danger |
Contributor
|
| App Name | WordPress | |
| Configuration | Release-Alpha | |
| Build Number | 33204 | |
| Version | PR #25798 | |
| Bundle ID | org.wordpress.alpha | |
| Commit | 25be9bc | |
| Installation URL | 0k476343qodeg |
Contributor
|
| App Name | Jetpack | |
| Configuration | Release-Alpha | |
| Build Number | 33204 | |
| Version | PR #25798 | |
| Bundle ID | com.jetpack.alpha | |
| Commit | 25be9bc | |
| Installation URL | 3uddfc1id5bno |
jkmassel
approved these changes
Jul 19, 2026
jkmassel
left a comment
Contributor
There was a problem hiding this comment.
I tested this in the sim and it seems to work well!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.


Description
I started with fixing an issue where the share extensions show an "offline error" before showing the site list. Then decided to refactor the UI a little bit to make the fetching state inline, which aligns with most of the app UI.