Skip to content

Fix the loading sites UI in the share extensions#25798

Merged
crazytonyli merged 3 commits into
trunkfrom
bugfix/share-extension-site-list-loading-state
Jul 19, 2026
Merged

Fix the loading sites UI in the share extensions#25798
crazytonyli merged 3 commits into
trunkfrom
bugfix/share-extension-site-list-loading-state

Conversation

@crazytonyli

Copy link
Copy Markdown
Contributor

Description

I started with fixing an issue where the share extensions show an "offline error" before showing the site list. Then decided to refactor the UI a little bit to make the fetching state inline, which aligns with most of the app UI.

Fetching No sites Sites Failure

@crazytonyli crazytonyli added this to the 27.1 milestone Jul 17, 2026
@crazytonyli
crazytonyli requested a review from jkmassel July 17, 2026 07:27
@dangermattic

Copy link
Copy Markdown
Collaborator
2 Warnings
⚠️ This PR is larger than 500 lines of changes. Please consider splitting it into smaller PRs for easier and faster reviews.
⚠️ This PR is assigned to the milestone 27.1. This milestone is due in less than 4 days.
Please make sure to get it merged by then or assign it to a milestone with a later deadline.

Generated by 🚫 Danger

@wpmobilebot

Copy link
Copy Markdown
Contributor
App Icon📲 You can test the changes from this Pull Request in WordPress by scanning the QR code below to install the corresponding build.
App NameWordPress
ConfigurationRelease-Alpha
Build Number33204
VersionPR #25798
Bundle IDorg.wordpress.alpha
Commit25be9bc
Installation URL0k476343qodeg
Automatticians: You can use our internal self-serve MC tool to give yourself access to those builds if needed.

@wpmobilebot

Copy link
Copy Markdown
Contributor
App Icon📲 You can test the changes from this Pull Request in Jetpack by scanning the QR code below to install the corresponding build.
App NameJetpack
ConfigurationRelease-Alpha
Build Number33204
VersionPR #25798
Bundle IDcom.jetpack.alpha
Commit25be9bc
Installation URL3uddfc1id5bno
Automatticians: You can use our internal self-serve MC tool to give yourself access to those builds if needed.

@jkmassel jkmassel left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I tested this in the sim and it seems to work well!

@crazytonyli
crazytonyli added this pull request to the merge queue Jul 19, 2026
Merged via the queue into trunk with commit dfc25f3 Jul 19, 2026
26 checks passed
@crazytonyli
crazytonyli deleted the bugfix/share-extension-site-list-loading-state branch July 19, 2026 07:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants