Skip to content

Reader: Integrate ReaderPostHeaderView #25465

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
kean wants to merge 9 commits into
base: trunk
Choose a base branch
from
Open

Reader: Integrate ReaderPostHeaderView #25465

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
9 commits
Select commit Hold shift + click to select a range
0d2879f
Integrate ReaderPostHeaderView
kean Mar 30, 2026
f62f047
Fix a typo
crazytonyli May 26, 2026
ce10352
Update an unit test
crazytonyli May 26, 2026
00c35c5
Estimate reading time for scripts without word spaces
crazytonyli May 26, 2026
29c3f4f
Merge remote-tracking branch 'origin/trunk' into task/reader-integrat…
crazytonyli Jun 22, 2026
b962966
Remove unused reading time estimation from the Reader post header
crazytonyli Jun 22, 2026
e7675ce
Keep the Reader header subscribe button visible for followed sites
crazytonyli Jun 22, 2026
446af4f
Fix Reader header excerpt theming and author row accessibility
crazytonyli Jun 22, 2026
42e2e01
Track image taps on the Reader header featured image
crazytonyli Jun 22, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions Modules/Sources/WordPressData/Mapping/ReaderPost+Mapping.swift
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -73,6 +73,7 @@ extension ReaderPost {
permaLink = remotePost.permalink
postID = remotePost.postID
postTitle = remotePost.postTitle
mt_excerpt = remotePost.excerpt?.nonEmptyString()
railcar = remotePost.railcar
score = remotePost.score
siteID = remotePost.siteID
Expand Down
1 change: 1 addition & 0 deletions Modules/Sources/WordPressKitObjC/RemoteReaderPost.m
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -134,6 +134,7 @@ - (instancetype)initWithDictionary:(NSDictionary *)dict;
self.sortDate = [self sortDateFromPostDictionary:dict];
self.sortRank = @(self.sortDate.timeIntervalSinceReferenceDate);
self.status = [self stringOrEmptyString:[dict stringForKey:PostRESTKeyStatus]];
self.excerpt = [self stringOrEmptyString:[dict stringForKey:PostRESTKeyExcerpt]];
self.summary = [self postSummaryFromPostDictionary:dict orPostContent:self.content];
self.tags = [self tagsFromPostDictionary:dict];
self.isSharingEnabled = [[dict numberForKey:PostRESTKeySharingEnabled] boolValue];
Expand Down
2 changes: 2 additions & 0 deletions Modules/Sources/WordPressKitObjC/include/RemoteReaderPost.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -38,6 +38,8 @@ NS_ASSUME_NONNULL_BEGIN
@property (nonatomic, strong, nullable) NSNumber *siteID;
@property (nonatomic, strong, nullable) NSDate *sortDate;
@property (nonatomic, strong, nullable) NSNumber *sortRank;
/// - warning: It may still contain auto-generated excerpts, but they are not automatically trimmed like `summary`.
@property (nonatomic, strong, nullable) NSString *excerpt;
@property (nonatomic, strong, nullable) NSString *summary;
@property (nonatomic, strong, nullable) NSString *tags;
@property (nonatomic) BOOL isLikesEnabled;
Expand Down
Loading