Use container-relative constraints instead of UIScreen.main.bounds in ErrorStateView#25685
Open
crazytonyli wants to merge 1 commit into
Open
Use container-relative constraints instead of UIScreen.main.bounds in ErrorStateView#25685crazytonyli wants to merge 1 commit into
crazytonyli wants to merge 1 commit into
Conversation
crazytonyli
commented
Jun 23, 2026
crazytonyli
commented
Contributor
| Before | After | |
|---|---|---|
| iPad |  |
 |
| iPhone |  |
 |
… ErrorStateView The error state view sized its content width and positioned its dismissal control as fractions of the main screen, computed during init before the view had a window. Those are now Auto Layout constraints relative to the view itself (which fills the screen), so they resolve at layout time and adapt to the actual container without reading the deprecated shared screen.
Contributor
|
| App Name | WordPress | |
| Configuration | Release-Alpha | |
| Build Number | 32747 | |
| Version | PR #25685 | |
| Bundle ID | org.wordpress.alpha | |
| Commit | f3359fd | |
| Installation URL | 5sr45k2m851no |
Contributor
|
| App Name | Jetpack | |
| Configuration | Release-Alpha | |
| Build Number | 32747 | |
| Version | PR #25685 | |
| Bundle ID | com.jetpack.alpha | |
| Commit | f3359fd | |
| Installation URL | 256j8t42abdeg |
jkmassel
requested changes
Jun 24, 2026
jkmassel
left a comment
jkmassel
left a comment
Contributor
There was a problem hiding this comment.
Claude flagged some potential RTL issues here.
I wonder though, if we should just remove ErrorStateView and replace it with ContentUnavailableView? It seems like a good opportunity to delete a bunch of code. WDYT?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.