Localization: drop stale WordPressKit remote-extraction path#25691
Merged
mokagio merged 2 commits intoJun 25, 2026
Conversation
WordPressKit is vendored under Modules/Sources, so it's already covered by the Modules/Sources/ genstrings path; the remote SourcePackages/checkouts/WordPressKit-iOS/Sources path no longer resolves. Empty the list.
mokagio
reviewed
Jun 24, 2026
mokagio
approved these changes
Jun 24, 2026
Co-authored-by: Gio Lodi <gio@mokacoding.com>
github-merge-queue
Bot
removed this pull request from the merge queue due to failed status checks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Minimal cleanup spotted while auditing the localization pipeline.
Summary
REMOTE_SWIFT_PACKAGES_TO_LOCALIZElistedWordPressKit-iOS, sogenerate_strings_fileaddedDerivedData/SourcePackages/checkouts/WordPressKit-iOS/Sourcesto thegenstringsinputs.Modules/Sources/WordPressKit(declared locally inModules/Package.swift, absent fromPackage.resolved) — so it's already covered by the existingModules/Sources/path, and the remote checkout path no longer resolves.Change
REMOTE_SWIFT_PACKAGES_TO_LOCALIZE = []) and update the comment. The extraction scaffolding stays in place for any future remote, string-bearing package.Test plan
complete_code_freeze→generate_strings_file_for_glotpressstill extracts WordPressKit's strings (now viaModules/Sources/).Pre-existing and unrelated to #25688 — filed separately on purpose.