Skip to content

Fix injecting keychain instances#25704

Merged
crazytonyli merged 1 commit into
trunkfrom
task/fix-unit-test-keychain
Jun 26, 2026
Merged

Fix injecting keychain instances#25704
crazytonyli merged 1 commit into
trunkfrom
task/fix-unit-test-keychain

Conversation

@crazytonyli

Copy link
Copy Markdown
Contributor

The updated Blog functions all accept a keychainImplementation: KeychainAccessible = AppKeychain() parameter. But there is another way to inject test keychain: Blog.keychain. This PR makes them compatible with each other. The priority is: function parameter > Blog.keychain the stored property.

Only unit tests are affected by this PR. The production code continues to use AppKeychain.

This PR fixes test failures in #25702.

@crazytonyli crazytonyli added this to the 27.1 milestone Jun 26, 2026
@crazytonyli crazytonyli requested a review from jkmassel June 26, 2026 03:09
@crazytonyli crazytonyli added the Testing Unit and UI Tests and Tooling label Jun 26, 2026
@crazytonyli crazytonyli enabled auto-merge June 26, 2026 03:10
@wpmobilebot

Copy link
Copy Markdown
Contributor
App Icon📲 You can test the changes from this Pull Request in WordPress by scanning the QR code below to install the corresponding build.
App NameWordPress
ConfigurationRelease-Alpha
Build Number32850
VersionPR #25704
Bundle IDorg.wordpress.alpha
Commite3f4d63
Installation URL4631ag3qt4hm8
Automatticians: You can use our internal self-serve MC tool to give yourself access to those builds if needed.

@wpmobilebot

Copy link
Copy Markdown
Contributor
App Icon📲 You can test the changes from this Pull Request in Jetpack by scanning the QR code below to install the corresponding build.
App NameJetpack
ConfigurationRelease-Alpha
Build Number32850
VersionPR #25704
Bundle IDcom.jetpack.alpha
Commite3f4d63
Installation URL0756g6s0pv1r8
Automatticians: You can use our internal self-serve MC tool to give yourself access to those builds if needed.

@crazytonyli crazytonyli added this pull request to the merge queue Jun 26, 2026
Merged via the queue into trunk with commit 5fbce59 Jun 26, 2026
24 checks passed
@crazytonyli crazytonyli deleted the task/fix-unit-test-keychain branch June 26, 2026 17:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Testing Unit and UI Tests and Tooling

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants