Apply review nitpicks from the TestFlight CI PR (#25674)#25709
Merged
Conversation
The shell-script and pipeline.yml header comments carried "Faster Releases" rollout context that's only relevant while the project is in flight. Drop it, keep the factual one-liners, and switch the build step to the :testflight: emoji to match the matrix group. Addresses review feedback from #25674.
The "intentionally additive / source of truth until proven" and "wired up in later phases of the RFC" paragraphs describe the rollout state, not the lane. Keep the build-code explanation, which documents behavior that outlives the project. Addresses review feedback from #25674.
The env check sat after the case statement, so a missing build number only surfaced after update_certs_and_profiles_* had already run. Move the check to the top of the lane to fail before any cert/profile work. Addresses review feedback from #25674.
- Tag the placeholder "what's new" comment TODO instead of TBD, which isn't a convention anyone greps for. - Spell the changelog env fallbacks "unknown branch" / "unknown commit" so a missing value reads as such. - Manage the temp file with Dir.mktmpdir's block form, which cleans up the directory itself instead of a manual begin/ensure rm. Addresses review feedback from #25674.
The lane is named build_all_apps_for_testflight but only builds WordPress and Jetpack. Print a visible heads-up at runtime so someone running it locally isn't left wondering where the Reader build went. Addresses review feedback from #25674.
Contributor
|
| App Name | WordPress | |
| Configuration | Release-Alpha | |
| Build Number | 32864 | |
| Version | PR #25709 | |
| Bundle ID | org.wordpress.alpha | |
| Commit | 599f7d6 | |
| Installation URL | 2o1ttr88g1ob0 |
Contributor
|
| App Name | Jetpack | |
| Configuration | Release-Alpha | |
| Build Number | 32864 | |
| Version | PR #25709 | |
| Bundle ID | com.jetpack.alpha | |
| Commit | 599f7d6 | |
| Installation URL | 0o0ohl78ikgc8 |
oguzkocer
approved these changes
Jun 26, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
@mokagio made a bunch of suggestions in #25674 and I forgot to apply them 🤦 .
Each item is its own commit:
pipeline.ymlheader comments carried "Faster Releases" rollout context that's only relevant while the project is in flight. Also switches the build step to the:testflight:emoji to match the matrix group.BUILDKITE_BUILD_NUMBERbefore building — the env check sat after thecasestatement, so a missing build number only surfaced afterupdate_certs_and_profiles_*had already run. Moved to the top of the lane to fail early.TBD→TODO(an actually-greppable tag), spell the changelog fallbacksunknown branch/unknown commit, and manage the temp file withDir.mktmpdir's block form instead of a manualbegin/ensure rm.build_all_apps_for_testflightonly builds WordPress and Jetpack despite the name; prints aUI.importantheads-up so a local runner isn't left wondering where the Reader build went.Test plan
fastlane build_all_apps_for_testflight(or a trunk build after merge) still builds and uploads WordPress and Jetpack to TestFlight internal testers, with the same build code and:testflight:step label.Related