-
Notifications
You must be signed in to change notification settings - Fork 1.2k
Adopt a8c-secrets in WordPress iOS #25772
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: trunk
Are you sure you want to change the base?
Changes from 15 commits
1159d12
79f9bf3
f9d0081
897638f
3f93d5c
c84f12d
fd02fe8
0dde17e
9e5343b
b27a909
cd93e97
971a798
3143cc4
4ae70a1
7de0240
4346fee
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,4 @@ | ||
| # dev | ||
| age1srcq3hl92ym9jk3ezj5prwhche3w8szc0cssy8t7afrkjmtkxu2qkjsdfn | ||
| # ci | ||
| age1a7xcr6qzwnzgcxq95sq33p58xdzsmful8w7mp2zktvuy5434yuss9rmv8f | ||
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1 @@ | ||
| wordpress-ios@github.com@wordpress-mobile |
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,9 @@ | ||
| #!/usr/bin/env bash | ||
|
|
||
| set -euo pipefail | ||
|
|
||
| echo "--- :closed_lock_with_key: Installing Secrets" | ||
| curl -fsSL https://raw.githubusercontent.com/Automattic/a8c-secrets/main/install.sh | bash | ||
| # The installer puts the binary in ~/.local/bin, which isn't on the agent's PATH. | ||
| export PATH="$HOME/.local/bin:$PATH" | ||
|
Comment on lines
+6
to
+8
Contributor
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Note that in the future we plan to have Alternatively, maybe we could start deploying the |
||
| bundle exec fastlane configure_secrets | ||
This file was deleted.
This file was deleted.
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,4 +1,4 @@ | ||
| RELEASE-NOTES.txt merge=union | ||
| *.strings diff=localizablestrings | ||
|
|
||
| .configure-files/*.enc binary | ||
| .a8c-secrets/*.age binary |
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,10 +1,8 @@ | ||
| # Lists of input files for the script that populates the app's secrets with the | ||
| # correct values for the current scheme and build configuration. | ||
| ${HOME}/.configure/wordpress-ios/secrets/WordPress-Secrets.swift | ||
| ${HOME}/.configure/wordpress-ios/secrets/WordPress-Secrets-Internal.swift | ||
| ${HOME}/.configure/wordpress-ios/secrets/WordPress-Secrets-Alpha.swift | ||
| ${HOME}/.configure/wordpress-ios/secrets/Jetpack-Secrets.swift | ||
| ${HOME}/.configure/wordpress-ios/secrets/Reader-Secrets.swift | ||
| ${HOME}/.a8c-secrets/wordpress-ios@github.com@wordpress-mobile/WordPress-Secrets.swift | ||
| ${HOME}/.a8c-secrets/wordpress-ios@github.com@wordpress-mobile/Jetpack-Secrets.swift | ||
| ${HOME}/.a8c-secrets/wordpress-ios@github.com@wordpress-mobile/Reader-Secrets.swift | ||
|
Comment on lines
-3
to
+5
Contributor
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Is it intentional that the 3 I looked at the current 3 files in our
So in practice this migration to have a single
Contributor
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Ok reading the current content of the
Contributor
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. We no longer need any of the differentiated secrets files – everything can use the same credentials.
Contributor
Author
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more.
Consolidation to a single secret file felt like a bigger change than what this PR ought to hold. I reverted this to draft and opened #25803 to work on it. |
||
|
|
||
| # Local Secrets file that external contributors can use to specify their own | ||
| # ClientID and Secrets. This file is created by the Rakefile when external | ||
|
|
||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
CI public key validated by using
age-keygen -yon the private key stored in our CI secrets 👍