Skip to content

Fix the loading sites UI in the share extensions #25798

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
crazytonyli merged 3 commits into from
Jul 19, 2026
+405 −131
Merged

Fix the loading sites UI in the share extensions #25798

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
427dc27
Format share extension site picker
crazytonyli Jul 17, 2026
7369cf7
Show site fetch states inline in share extension
crazytonyli Jul 17, 2026
25be9bc
Add a release note
crazytonyli Jul 17, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 14 additions & 0 deletions Modules/Sources/WordPressUI/Deprecated/NoResultsViewController.swift
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -174,6 +174,20 @@ import WordPressShared
displayTitleViewOnly = false
}

/// Configures the view for an in-progress operation without replacing it with the no-connection presentation.
public func configureForLoading(title: String) {
titleText = title
subtitleText = nil
attributedSubtitleText = nil
configureAttributedSubtitle = nil
attributedTitleText = nil
buttonText = nil
imageName = nil
subtitleImageName = nil
accessorySubview = Self.loadingAccessoryView()
displayTitleViewOnly = false
}

/// Public method to show the title specifically formatted for no search results.
/// When the view is configured, it will display just a label with specific constraints.
///
Expand Down
1 change: 1 addition & 0 deletions RELEASE-NOTES.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,6 +5,7 @@
* [*] [build tooling] Add a String Catalog localization pipeline (plurals + build-free catalog generation) with a CI coverage gate [#25688]
* [*] [internal] Stats widgets: migrate the site picker from SiriKit to App Intents [#25753]
* [*] Fix Blogging Reminders text color in dark mode [#25780]
* [*] Share extensions: Fix the site picker showing an error while sites are still loading [#25798]

27.0
-----
Expand Down
Loading