Clear first-party warnings from the cross-platform swift test job

[jkmassel]

Description

The cross-platform swift test job added in #25344 surfaces a handful of warnings that the iOS app build hides — Xcode suppresses warnings from SPM package dependencies, and WordPressCore / WordPressCoreTests build in Swift 6 language mode (neither package sets .swiftLanguageMode(.v5) on them). This clears the first-party ones. All are dead code or a missing conformance — no behavior change.

1. Dead await — UserService.fetchUsers()

users.sequenceWithEditContext(params:) builds a PaginationSequence synchronously; the async throws is on iteration (for try await), not construction. Dropped the await.

2. Dead try ×3 — WordPressClientFeatureTests

WordPressClient(api:siteURL:) is non-throwing. Dropped the three try; each test keeps its other try await client.supports(…) calls, so throws stays justified.

3. Missing @unchecked Sendable restatement ×5 — MockWordPressClientAPI

The five mock executors subclass wordpress-rs's @unchecked Sendable base classes; Swift 6 requires restating the conformance on the subclass. Their added stored properties (routes / isBlockTheme) are set-in-init and read-only, so @unchecked is honest.

All three are correct for iOS too — same sources, same wordpress-rs binary, no platform conditionals.

The remaining swiftsoup "unhandled files" warning is upstream and handled separately in #25811.

Testing instructions

• swift test (cross-platform package) — 128 tests pass and the three first-party warning classes above are gone. (The upstream swiftsoup warning still shows on this branch; Update SwiftSoup from 2.7.5 to 2.13.6 #25811 removes it.)
• CI — Swift Package Tests, plus WordPress/Jetpack Unit Tests (WordPressCoreTests runs in both).

Related

• Follows up Add cross-platform Swift package tests for macOS #25344 (its stated next step: "clean up swift test warnings")
• Sibling of Update SwiftSoup from 2.7.5 to 2.13.6 #25811 (SwiftSoup bump — the upstream warning)

[wpmobilebot]

📲 You can test the changes from this Pull Request in WordPress by scanning the QR code below to install the corresponding build.

	App Name	WordPress
	Configuration	Release-Alpha
	Build Number	33319
	Version	PR #25813
	Bundle ID	org.wordpress.alpha
	Commit	dcd758a
	Installation URL	28t9dt935jmk0

Automatticians: You can use our internal self-serve MC tool to give yourself access to those builds if needed.

[wpmobilebot]

📲 You can test the changes from this Pull Request in Jetpack by scanning the QR code below to install the corresponding build.

	App Name	Jetpack
	Configuration	Release-Alpha
	Build Number	33319
	Version	PR #25813
	Bundle ID	com.jetpack.alpha
	Commit	dcd758a
	Installation URL	2cjg068q7f6vo

Automatticians: You can use our internal self-serve MC tool to give yourself access to those builds if needed.