Skip to content

Clear first-party warnings from the cross-platform swift test job #25813

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
jkmassel merged 1 commit into from
Jul 22, 2026
+9 −9
Merged

Clear first-party warnings from the cross-platform swift test job #25813

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion Modules/Sources/WordPressCore/Users/UserService.swift
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -23,7 +23,7 @@ public actor UserService: UserServiceProtocol {
}

public func fetchUsers() async throws {
let sequence = await client.api.users.sequenceWithEditContext(params: .init(perPage: 100))
let sequence = client.api.users.sequenceWithEditContext(params: .init(perPage: 100))
var started = false
for try await users in sequence {
if !started {
Expand Down
10 changes: 5 additions & 5 deletions Modules/Tests/WordPressCoreTests/MockWordPressClientAPI.swift
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -92,7 +92,7 @@ final class MockWordPressClientAPI: WordPressClientAPI, @unchecked Sendable {

// MARK: - Mock Executors

final class MockApiRootRequestExecutor: ApiRootRequestExecutor {
final class MockApiRootRequestExecutor: ApiRootRequestExecutor, @unchecked Sendable {
private var routes: Set<String>

init(routes: Set<String>) {
Expand All @@ -112,7 +112,7 @@ final class MockApiRootRequestExecutor: ApiRootRequestExecutor {
}
}

final class MockUsersRequestExecutor: UsersRequestExecutor {
final class MockUsersRequestExecutor: UsersRequestExecutor, @unchecked Sendable {
override init(noHandle: UsersRequestExecutor.NoHandle) {
super.init(noHandle: noHandle)
}
Expand Down Expand Up @@ -148,7 +148,7 @@ final class MockUsersRequestExecutor: UsersRequestExecutor {
}
}

final class MockThemesRequestExecutor: ThemesRequestExecutor {
final class MockThemesRequestExecutor: ThemesRequestExecutor, @unchecked Sendable {
private var isBlockTheme: Bool

init(isBlockTheme: Bool) {
Expand Down Expand Up @@ -191,7 +191,7 @@ final class MockThemesRequestExecutor: ThemesRequestExecutor {
}
}

final class MockSiteSettingsRequestExecutor: SiteSettingsRequestExecutor {
final class MockSiteSettingsRequestExecutor: SiteSettingsRequestExecutor, @unchecked Sendable {
override init(noHandle: SiteSettingsRequestExecutor.NoHandle) {
super.init(noHandle: noHandle)
}
Expand Down Expand Up @@ -235,7 +235,7 @@ final class MockSiteSettingsRequestExecutor: SiteSettingsRequestExecutor {
}
}

final class MockWpApiDetails: WpApiDetails {
final class MockWpApiDetails: WpApiDetails, @unchecked Sendable {
private var routes: Set<String>

init(routes: Set<String>) {
Expand Down
6 changes: 3 additions & 3 deletions Modules/Tests/WordPressCoreTests/WordPressClientFeatureTests.swift
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -26,7 +26,7 @@ struct WordPressClientCachingTests {
mockAPI.mockRoutes = ["/wp-block-editor/v1/settings"]
mockAPI.mockIsBlockTheme = true

let client = try WordPressClient(api: mockAPI, siteURL: URL(string: "https://example.com")!)
let client = WordPressClient(api: mockAPI, siteURL: URL(string: "https://example.com")!)

// First call - should trigger API fetches
let result1 = try await client.supports(.blockEditorSettings)
Expand Down Expand Up @@ -61,7 +61,7 @@ struct WordPressClientCachingTests {
let mockAPI = MockWordPressClientAPI()
mockAPI.mockRoutes = ["/wp-block-editor/v1/sites/12345/settings"]

let client = try WordPressClient(api: mockAPI, siteURL: URL(string: "https://example.com")!)
let client = WordPressClient(api: mockAPI, siteURL: URL(string: "https://example.com")!)

// Call with siteId
let result = try await client.supports(.blockEditorSettings, forSiteId: 12345)
Expand All @@ -81,7 +81,7 @@ struct WordPressClientCachingTests {
mockAPI.mockRoutes = ["/wp-block-editor/v1/settings", "/wp/v2/plugins"]
mockAPI.mockIsBlockTheme = true

let client = try WordPressClient(api: mockAPI, siteURL: URL(string: "https://example.com")!)
let client = WordPressClient(api: mockAPI, siteURL: URL(string: "https://example.com")!)

// Make multiple concurrent calls
async let result1 = client.supports(.blockEditorSettings)
Expand Down