Add test for RemoteBlogSettings encoding to dictionary

Author: mokagio

Sources/WordPressKit/Services/BlogServiceRemoteREST.h

@@ -68,5 +68,6 @@ typedef void (^SettingsHandler)(RemoteBlogSettings *settings);
 
 // FIXME: Temporary public for testing. Will remove once the logic moves to Swift
 - (RemoteBlogSettings *)remoteBlogSettingFromJSONDictionary:(NSDictionary *)json;
+- (NSDictionary *)remoteSettingsToDictionary:(RemoteBlogSettings *)settings;
 
 @end

Tests/WordPressKitTests/Tests/RemoteBlogSettingsTests.swift

@@ -4,11 +4,7 @@ import XCTest
 final class RemoteBlogSettingsTests: XCTestCase {
 
     func testInitWithJSON() throws {
-        let jsonPath = try XCTUnwrap(
-            Bundle(for: type(of: self))
-                .path(forResource: "rest-site-settings", ofType: "json")
-        )
-        let json = try XCTUnwrap(JSONLoader().loadFile(jsonPath))
+        let json = try loadJSONSettings()
         // FIXME: The init logic is currently in BlogServiceRemoteREST. We'll test it from there first, then update the test with the new location.
         let blogService = BlogServiceRemoteREST(wordPressComRestApi: MockWordPressComRestApi(), siteID: 0)
         let settings = try XCTUnwrap(blogService.remoteBlogSetting(fromJSONDictionary: json))
@@ -27,4 +23,38 @@ final class RemoteBlogSettingsTests: XCTestCase {
         // Note that here we're obviously testing only one of the possible paths.
         XCTAssertEqual(settings.defaultPostFormat, "standard")
     }
+
+    func testToDictionary() throws {
+        // Rather than creating an object and checking the resulting NSDictionary,
+        // let's load one, convert it, then compare the source and converted dictionaries
+        let json = try loadJSONSettings()
+        // FIXME: The init logic is currently in BlogServiceRemoteREST. We'll test it from there first, then update the test with the new location.
+        let blogService = BlogServiceRemoteREST(wordPressComRestApi: MockWordPressComRestApi(), siteID: 0)
+        let settings = try XCTUnwrap(blogService.remoteBlogSetting(fromJSONDictionary: json))
+
+        let dictionary = try XCTUnwrap(blogService.remoteSettings(toDictionary: settings))
+
+        // name and tagline have different keys when encoded...
+        XCTAssertEqual(dictionary["blogname"] as? String, settings.name) // from JSON this is "name"
+        XCTAssertEqual(dictionary["blogdescription"] as? String, settings.tagline) // from JSON this is "description"
+        // Flattened settings properties
+        XCTAssertEqual(dictionary["blog_public"] as? NSNumber, settings.privacy)
+        XCTAssertEqual(dictionary["lang_id"] as? NSNumber, settings.languageID)
+        XCTAssertEqual(dictionary["site_icon"] as? NSNumber, settings.iconMediaID)
+        XCTAssertEqual(dictionary["gmt_offset"] as? NSNumber, settings.gmtOffset)
+        // And so on...
+
+        // defaultPostFormat has custom encoding, so let's test it explicitly.
+        // Note that here we're obviously testing only one of the possible paths.
+        XCTAssertEqual(dictionary["default_post_format"] as? String, settings.defaultPostFormat)
+    }
+
+    func loadJSONSettings() throws -> [String: Any] {
+        let jsonPath = try XCTUnwrap(
+            Bundle(for: type(of: self))
+                .path(forResource: "rest-site-settings", ofType: "json")
+        )
+        let json = try XCTUnwrap(JSONLoader().loadFile(jsonPath))
+        return json
+    }
 }