Use common function to get project root and name, to also help with unit testing

Author: iangmaia

lib/fastlane/plugin/wpmreleasetoolkit/helper/ios/ios_git_helper.rb

@@ -18,11 +18,11 @@ module GitHelper
         # @param [Bool] include_metadata If true (the default), includes the `fastlane/download_metadata.swift` file and the `.pot` file (which typically contains an entry or release notes for the new version)
         #
         def self.commit_version_bump(include_deliverfile: true, include_metadata: true)
-          files_list = [File.join(ENV['PROJECT_ROOT_FOLDER'], 'config', '.')]
+          files_list = [File.join(get_project_root(), 'config', '.')]
           files_list.append File.join('fastlane', 'Deliverfile') if include_deliverfile
           if include_metadata
             files_list.append File.join('fastlane', 'download_metadata.swift')
-            files_list.append File.join(ENV['PROJECT_ROOT_FOLDER'], ENV['PROJECT_NAME'], 'Resources', ENV['APP_STORE_STRINGS_FILE_NAME'])
+            files_list.append File.join(get_project_root(), get_project_name(), 'Resources', get_from_env!(key: 'APP_STORE_STRINGS_FILE_NAME'))
           end
 
           Fastlane::Helper::GitHelper.commit(message: 'Bump version number', files: files_list, push: true)
@@ -54,7 +54,7 @@ def self.localize_project
         #       in the release-toolkit instead, and move this code away from `ios_git_helper`.
         #
         def self.update_metadata
-          Action.sh("cd #{get_from_env!(key: 'PROJECT_ROOT_FOLDER')} && ./Scripts/update-translations.rb")
+          Action.sh("cd #{get_project_root()} && ./Scripts/update-translations.rb")
 
           Fastlane::Helper::GitHelper.commit(message: 'Update translations', files: strings_files, push: false)
 
@@ -64,12 +64,20 @@ def self.update_metadata
         end
 
         def self.strings_files
-          project_root = get_from_env!(key: 'PROJECT_ROOT_FOLDER')
-          project_name = get_from_env!(key: 'PROJECT_NAME')
+          project_root = get_project_root()
+          project_name = get_project_name()
 
           Dir.glob(File.join(project_root, project_name, '**', '*.strings'))
         end
 
+        def self.get_project_root
+          get_from_env!(key: 'PROJECT_ROOT_FOLDER')
+        end
+
+        def self.get_project_name
+          get_from_env!(key: 'PROJECT_NAME')
+        end
+
         def self.get_from_env!(key:)
           ENV.fetch(key) do
             UI.user_error! "Could not find value for \"#{key}\" in environment."