Address openai_ask review polish

Author: iangmaia

CHANGELOG.md

@@ -14,11 +14,11 @@ _None_
 
 ### Bug Fixes
 
-- `openai_ask`: improve tool-use handling by requiring named function tools, using `max_completion_tokens`, opting out of OpenAI request storage, omitting sensitive tool diagnostics from logs, and refusing to execute additional tool calls after `max_tool_iterations`. [#719]
+- `openai_ask`: avoid logging sensitive tool diagnostics and refuse to execute additional tool calls after `max_tool_iterations`. [#719]
 
 ### Internal Changes
 
-_None_
+- `openai_ask`: validate named function tools, use `max_completion_tokens`, and opt out of OpenAI request storage. [#719]
 
 ## 14.5.0
 

lib/fastlane/plugin/wpmreleasetoolkit/actions/common/openai_ask_action.rb

@@ -8,6 +8,7 @@ module Fastlane
   module Actions
     class OpenaiAskAction < Action
       OPENAI_API_ENDPOINT = URI('https://api.openai.com/v1/chat/completions').freeze
+      # Preserve the previous `max_tokens` ceiling while using the current API field.
       DEFAULT_MAX_COMPLETION_TOKENS = 2048
       DEFAULT_MAX_TOOL_ITERATIONS = 5
       DEFAULT_MODEL = 'gpt-4o'
@@ -49,6 +50,7 @@ def self.run(params)
         validate_tools_array!(tools)
         validate_max_tool_iterations!(max_tool_iterations)
         validate_tools!(tools)
+
         run_with_tools(
           prompt: prompt,
           question: question,
@@ -164,7 +166,7 @@ def self.validate_tools_array!(tools)
       def self.validate_tools!(tools)
         invalid_tools = tools.each_with_index.filter_map do |tool, index|
           type = tool_type(tool)
-          next "tools[#{index}] type #{type.empty? ? '<missing>' : type.inspect}" unless type == 'function'
+          next "tools[#{index}] type #{type.nil? ? '<missing>' : type.inspect}" unless type == 'function'
 
           function = tool[:function] || tool['function']
           name = function[:name] || function['name'] if function.is_a?(Hash)
@@ -182,9 +184,9 @@ def self.validate_tools!(tools)
       end
 
       def self.tool_type(tool)
-        return '' unless tool.is_a?(Hash)
+        return nil unless tool.is_a?(Hash)
 
-        (tool[:type] || tool['type']).to_s
+        (tool[:type] || tool['type'])&.to_s
       end
 
       def self.valid_tool_name?(name)