Merge pull request #464 from wordpress-mobile/update/octokit

Author: spencertransier

.rubocop.yml

@@ -48,6 +48,21 @@ Style/AsciiComments:
 # which would be incorrect and not what we want
 Style/StringConcatenation:
   Enabled: false
+  
+# This rule was enforced after upgrading Rubocop from `1.22.1` to `1.50.2`. We are disabling this rule for the
+# time being so that we don't see any unexpected behavior when running Release Toolkit actions that could be
+# changed by this rule. See https://github.com/wordpress-mobile/release-toolkit/pull/464#pullrequestreview-1396569629
+# for more discussion
+Style/FetchEnvVar:
+  Enabled: false
+  
+########## Gemspec Rules
+
+# This was turned on by default after updating Rubocop to `1.50.2`. We want to disable this for now because
+# all the gem publishing is done within CI and doesn't allow for user input such as an MFA code. See
+# https://github.com/wordpress-mobile/release-toolkit/pull/464#pullrequestreview-1396569313 for more discussion
+Gemspec/RequireMFA:
+  Enabled: false
 
 ########## Metrics / Max Lengths Rules
 

CHANGELOG.md

@@ -21,6 +21,8 @@ _None_
 - Add "Mobile Secrets" to `configure_update` current branch message to clarify which repo it's referring to. [#455]
 - `buildkite_trigger_build` now prints the web URL of the newly scheduled build, to allow you to easily open it via cmd-click. [#460]
 - Add the branch information to the 'This is not a release branch' error that's thrown from complete code freeze lane. [#461]
+- Update `octokit` to `5.6.1` This is a major version bump from version `4.18`, but is not a breaking change for the Release Toolkit because it doesn't change any public APIs for clients. [#464]
+- Update `danger` to `9.3.0`. This is an internal-only change and is not a breaking change for clients. [#464]
 - Adds `ignore_pipeline_branch_filters=true` parameter to the API call triggering a Buildkite build [#468]
 
 ## 7.0.0

Dangerfile

@@ -32,7 +32,7 @@ end
 
 # Lint with Rubocop and report violations inline in GitHub
 github.dismiss_out_of_range_messages # This way, fixed violations should go
-renaming_map = (git.renamed_files || []).map { |e| [e[:before], e[:after]] }.to_h # when files are renamed, git.modified_files contains old name, not new one, so we need to do the convertion
+renaming_map = (git.renamed_files || []).to_h { |e| [e[:before], e[:after]] } # when files are renamed, git.modified_files contains old name, not new one, so we need to do the convertion
 rubocop.lint(
   files: git.added_files + (git.modified_files.map { |f| renaming_map[f] || f }) - git.deleted_files,
   inline_comment: true,

Gemfile

@@ -2,7 +2,7 @@ source('https://rubygems.org')
 
 gemspec
 
-gem 'danger', '~> 8.0'
+gem 'danger', '~> 9.3'
 gem 'danger-rubocop', '~> 0.6'
 
 gem 'codecov', require: false