Move the optionality of is_draft to create_release_action

Author: Rynaard Burger

lib/fastlane/plugin/wpmreleasetoolkit/helper/github_helper.rb

@@ -119,16 +119,16 @@ def create_milestone(repository:, title:, due_date:, days_until_submission:, day
       # @param [String] description The text to use as the release's body / description (typically the release notes)
       # @param [Array<String>] assets List of file paths to attach as assets to the release
       # @param [TrueClass|FalseClass] prerelease Indicates if this should be created as a pre-release (i.e. for alpha/beta)
-      # @param [TrueClass|FalseClass] is_draft Indicates if this should be created as a draft release (defaults to true)
+      # @param [TrueClass|FalseClass] is_draft Indicates if this should be created as a draft release
       #
-      def create_release(repository:, version:, target: nil, description:, assets:, prerelease:, is_draft: true)
+      def create_release(repository:, version:, target: nil, description:, assets:, prerelease:, is_draft:)
         release = client.create_release(
           repository,
           version, # tag name
           name: version, # release name
           target_commitish: target || Git.open(Dir.pwd).log.first.sha,
-          draft: is_draft,
           prerelease: prerelease,
+          draft: is_draft,
           body: description
         )
         assets.each do |file_path|

spec/github_helper_spec.rb

@@ -398,7 +398,7 @@ def create_milestone(due_date:, days_until_submission:, days_until_release:)
     it 'has the correct options' do
       options = { body: test_description, draft: true, name: test_tag, prerelease: false, target_commitish: test_target }
       expect(client).to receive(:create_release).with(test_repo, test_tag, options)
-      create_release
+      create_release(is_draft: true)
     end
 
     it 'uploads the assets to the correct location' do
@@ -407,13 +407,13 @@ def create_milestone(due_date:, days_until_submission:, days_until_release:)
 
       allow(client).to receive(:create_release).and_return({ url: test_url })
       expect(client).to receive(:upload_asset).with(test_url, test_assets, { content_type: 'application/octet-stream' })
-      create_release(assets: [test_assets])
+      create_release(is_draft: true, assets: [test_assets])
     end
 
     it 'creates a draft release if is_draft is set to true' do
       options_draft_release = { body: test_description, draft: true, name: test_tag, prerelease: false, target_commitish: test_target }
       expect(client).to receive(:create_release).with(test_repo, test_tag, options_draft_release)
-      create_release
+      create_release(is_draft: true)
     end
 
     it 'creates a final (non-draft) release if is_draft is set to false' do
@@ -422,7 +422,7 @@ def create_milestone(due_date:, days_until_submission:, days_until_release:)
       create_release(is_draft: false)
     end
 
-    def create_release(assets: [], is_draft: true)
+    def create_release(is_draft:, assets: [])
       helper = described_class.new(github_token: 'Fake-GitHubToken-123')
       helper.create_release(
         repository: test_repo,