Find draft releases when uploading assets

Author: iangmaia

lib/fastlane/plugin/wpmreleasetoolkit/helper/github_helper.rb

@@ -192,16 +192,17 @@ def create_release(repository:, version:, description:, assets:, prerelease:, is
         release[:html_url]
       end
 
-      # Returns the GitHub release matching a given tag/version.
+      # Returns the GitHub release matching a given tag/version, including draft releases.
       #
       # @param [String] repository The repository to fetch the GitHub release from. Typically a repo slug (<org>/<repo>).
       # @param [String] version The release version/tag to fetch.
       # @return [Sawyer::Resource] The matching GitHub Release.
       # @raise [Fastlane::UI::Error] UI.user_error! if the release does not exist.
       #
       def get_release(repository:, version:)
-        client.release_for_tag(repository, version)
-      rescue Octokit::NotFound
+        release = client.releases(repository).find { |candidate| candidate.tag_name == version }
+        return release unless release.nil?
+
         UI.user_error!("Could not find GitHub Release for tag #{version} in #{repository}")
       end
 

spec/github_helper_spec.rb

@@ -624,7 +624,7 @@ def create_release(is_draft:, assets: [], name: nil)
     let(:test_version) { '1.0.0' }
     let(:release_url) { 'https://api.github.com/repos/repo-test/project-test/releases/123' }
     let(:release_html_url) { 'https://github.com/repo-test/project-test/releases/tag/1.0.0' }
-    let(:release) { sawyer_resource_stub(url: release_url, html_url: release_html_url) }
+    let(:release) { sawyer_resource_stub(url: release_url, html_url: release_html_url, tag_name: test_version) }
     let(:existing_assets) { [] }
     let(:uploaded_asset) { release_asset(name: 'test-app.zip', url: 'https://api.github.com/repos/repo-test/project-test/releases/assets/999') }
     let(:client) do
@@ -640,13 +640,13 @@ def create_release(is_draft:, assets: [], name: nil)
 
     before do
       allow(Octokit::Client).to receive(:new).and_return(client)
-      allow(client).to receive(:release_for_tag).with(test_repo, test_version).and_return(release)
+      allow(client).to receive(:releases).with(test_repo).and_return([release])
       allow(client).to receive(:release_assets).with(release_url).and_return(existing_assets)
       allow(client).to receive_messages(upload_asset: uploaded_asset, delete_release_asset: true)
     end
 
     it 'fails clearly if the release does not exist' do
-      allow(client).to receive(:release_for_tag).with(test_repo, test_version).and_raise(Octokit::NotFound)
+      allow(client).to receive(:releases).with(test_repo).and_return([])
 
       with_tmp_file(named: 'test-app.zip') do |file_path|
         expect do
@@ -656,7 +656,7 @@ def create_release(is_draft:, assets: [], name: nil)
     end
 
     it 'fails clearly if an asset file does not exist' do
-      expect(client).not_to receive(:release_for_tag)
+      expect(client).not_to receive(:releases)
       expect(client).not_to receive(:release_assets)
       expect(client).not_to receive(:upload_asset)
 
@@ -666,7 +666,7 @@ def create_release(is_draft:, assets: [], name: nil)
     end
 
     it 'fails clearly if an asset is not a file path' do
-      expect(client).not_to receive(:release_for_tag)
+      expect(client).not_to receive(:releases)
       expect(client).not_to receive(:release_assets)
       expect(client).not_to receive(:upload_asset)
 
@@ -687,7 +687,7 @@ def create_release(is_draft:, assets: [], name: nil)
         File.write(first_file_path, 'ios')
         File.write(second_file_path, 'tvos')
 
-        expect(client).not_to receive(:release_for_tag)
+        expect(client).not_to receive(:releases)
         expect(client).not_to receive(:release_assets)
         expect(client).not_to receive(:delete_release_asset)
         expect(client).not_to receive(:upload_asset)
@@ -698,6 +698,22 @@ def create_release(is_draft:, assets: [], name: nil)
       end
     end
 
+    it 'uploads assets to a draft release' do
+      draft_release = sawyer_resource_stub(url: release_url, html_url: release_html_url, tag_name: test_version, draft: true)
+      other_release = sawyer_resource_stub(url: 'https://api.github.com/repos/repo-test/project-test/releases/456', html_url: 'https://github.com/repo-test/project-test/releases/tag/0.9.0', tag_name: '0.9.0')
+
+      allow(client).to receive(:releases).with(test_repo).and_return([other_release, draft_release])
+      allow(client).to receive(:release_assets).with(release_url).and_return([])
+
+      with_tmp_file(named: 'test-app.zip') do |file_path|
+        expect(client).to receive(:upload_asset).with(release_url, file_path, { content_type: 'application/octet-stream' })
+
+        result = upload_release_assets(assets: [file_path])
+
+        expect(result).to eq(release_html_url)
+      end
+    end
+
     it 'uploads one asset to the existing release' do
       with_tmp_file(named: 'test-app.zip') do |file_path|
         expect(client).to receive(:upload_asset).with(release_url, file_path, { content_type: 'application/octet-stream' })