Skip to content

Commit 5a35628

Browse files
committed
Remove Bundler dependency and use Gemfile for dev
Removing the Bundler dependency definition allows us to use the latest bundler version (4.x vs 2.x). Additionally, it is no longer recommended to use the dev dependencies API, it's best to use Gemfile instead. See rubygems/bundler#7222
1 parent 362773d commit 5a35628

3 files changed

Lines changed: 15 additions & 19 deletions

File tree

Gemfile

Lines changed: 14 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -4,12 +4,23 @@ source('https://rubygems.org')
44

55
gemspec
66

7+
# Only needed for specs (Time.use_zone, String#to_time, Hash#slice!)
8+
gem 'activesupport', '~> 8.1'
79
gem 'buildkite-test_collector', '~> 2.3'
810
gem 'codecov', require: false
911
gem 'danger-dangermattic', '~> 1.0'
10-
gem 'webmock', require: false
11-
gem 'yard'
12-
1312
# Security: https://github.com/lostisland/faraday/pull/1665
1413
# Faraday 2.0 is not compatible with Fastlane
1514
gem 'faraday', '~> 1.10', '>= 1.10.5'
15+
# Use at least Fastlane 2.210.0 to ensure compatibility with the Xcode 14 toolchain
16+
# See https://github.com/fastlane/fastlane/releases/tag/2.210.0
17+
gem 'fastlane', '~> 2.210'
18+
gem 'pry', '~> 0.12.2'
19+
gem 'rmagick', '~> 5.3'
20+
gem 'rspec', '~> 3.8'
21+
gem 'rspec_junit_formatter', '~> 0.4.1'
22+
gem 'rubocop', '~> 1.65'
23+
gem 'rubocop-rspec', '3.0'
24+
gem 'simplecov', '~> 0.16.1'
25+
gem 'webmock', require: false
26+
gem 'yard'

Gemfile.lock

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -436,7 +436,6 @@ PLATFORMS
436436
DEPENDENCIES
437437
activesupport (~> 8.1)
438438
buildkite-test_collector (~> 2.3)
439-
bundler (~> 2.0)
440439
codecov
441440
danger-dangermattic (~> 1.0)
442441
faraday (~> 1.10, >= 1.10.5)
@@ -453,4 +452,4 @@ DEPENDENCIES
453452
yard
454453

455454
BUNDLED WITH
456-
2.7.2
455+
4.0.14

fastlane-plugin-wpmreleasetoolkit.gemspec

Lines changed: 0 additions & 14 deletions
Original file line numberDiff line numberDiff line change
@@ -45,18 +45,4 @@ Gem::Specification.new do |spec|
4545

4646
# `google-cloud-storage` is required by fastlane, but we pin it in case it's not in the future
4747
spec.add_dependency 'google-cloud-storage', '~> 1.31'
48-
49-
# Only needed for specs (Time.use_zone, String#to_time, Hash#slice!)
50-
spec.add_development_dependency 'activesupport', '~> 8.1'
51-
spec.add_development_dependency 'bundler', '~> 2.0'
52-
# Use at least Fastlane 2.210.0 to ensure compatibility with the Xcode 14 toolchain
53-
# See https://github.com/fastlane/fastlane/releases/tag/2.210.0
54-
spec.add_development_dependency 'fastlane', '~> 2.210'
55-
spec.add_development_dependency 'pry', '~> 0.12.2'
56-
spec.add_development_dependency 'rmagick', '~> 5.3'
57-
spec.add_development_dependency 'rspec', '~> 3.8'
58-
spec.add_development_dependency 'rspec_junit_formatter', '~> 0.4.1'
59-
spec.add_development_dependency 'rubocop', '~> 1.65'
60-
spec.add_development_dependency 'rubocop-rspec', '3.0'
61-
spec.add_development_dependency 'simplecov', '~> 0.16.1'
6248
end

0 commit comments

Comments
 (0)