Skip to content

Commit 5c03a93

Browse files
committed
Address Copilot review on find_or_create_pull_request
- Reword the action's details: base is required (drop 'optionally targeting a specific base') to match the required `base` ConfigItem. - find_pull_request YARD: mark `base` as `[String?]` since it accepts nil.
1 parent 77cdeac commit 5c03a93

2 files changed

Lines changed: 2 additions & 2 deletions

File tree

lib/fastlane/plugin/wpmreleasetoolkit/actions/common/find_or_create_pull_request_action.rb

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -42,7 +42,7 @@ def self.description
4242

4343
def self.details
4444
<<~DETAILS
45-
Looks for an open Pull Request whose head is the given branch (optionally targeting a specific base),
45+
Looks for an open Pull Request whose head is the given branch and which targets the given base,
4646
and returns its URL if found. Otherwise, creates a new Pull Request and returns its URL.
4747
4848
This is useful for "rolling" automations (e.g. a daily translations or dependency-update job) that

lib/fastlane/plugin/wpmreleasetoolkit/helper/github_helper.rb

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -309,7 +309,7 @@ def comment_on_pr(project_slug:, pr_number:, body:, reuse_identifier: SecureRand
309309
# @param [String] repository The repository name, including the organization (e.g. `wordpress-mobile/wordpress-ios`)
310310
# @param [String] head The head branch to look for. May be given as `branch` or as the fully-qualified `owner:branch`;
311311
# when unqualified, it is automatically prefixed with the repository's owner.
312-
# @param [String] base The base branch the PR should target. If nil, PRs targeting any base are considered.
312+
# @param [String?] base The base branch the PR should target. If nil, PRs targeting any base are considered.
313313
# @param [String] state The PR state to match (`open`, `closed`, or `all`). Defaults to `open`.
314314
# @return [Sawyer::Resource, nil] The first matching Pull Request, or nil if none matches.
315315
#

0 commit comments

Comments
 (0)