Skip to content

Commit 6980bd9

Browse files
Don't need to specify that it's public
1 parent 6638650 commit 6980bd9

2 files changed

Lines changed: 10 additions & 18 deletions

File tree

lib/fastlane/plugin/wpmreleasetoolkit/actions/ios/ios_get_build_number.rb

Lines changed: 10 additions & 10 deletions
Original file line numberDiff line numberDiff line change
@@ -4,31 +4,31 @@ class IosGetBuildNumberAction < Action
44
def self.run(params)
55
require_relative '../../helper/ios/ios_version_helper'
66

7-
public_version_xcconfig_file = params[:public_version_xcconfig_file]
8-
Fastlane::Helper::Ios::VersionHelper.get_build_number(xcconfig_file: public_version_xcconfig_file)
7+
xcconfig_file_path = params[:xcconfig_file_path]
8+
Fastlane::Helper::Ios::VersionHelper.read_build_number_from_config_file(xcconfig_file_path)
99
end
1010

1111
#####################################################
1212
# @!group Documentation
1313
#####################################################
1414

1515
def self.description
16-
'Gets the public build number of the app'
16+
'Gets the build number of the app'
1717
end
1818

1919
def self.details
20-
'Gets the public build number of the app'
20+
'Gets the build number of the app'
2121
end
2222

2323
def self.available_options
2424
[
2525
FastlaneCore::ConfigItem.new(
26-
key: :public_version_xcconfig_file,
27-
env_name: 'FL_IOS_PUBLIC_VERSION_XCCONFIG_FILE',
28-
description: 'Path to the .xcconfig file containing the public build number',
29-
type: String,
26+
key: :xcconfig_file_path,
27+
env_name: 'FL_IOS_XCCONFIG_FILE_PATH',
28+
description: 'Path to the .xcconfig file containing the build number',
29+
is_string: false,
3030
optional: false
31-
),
31+
)
3232
]
3333
end
3434

@@ -38,7 +38,7 @@ def self.output
3838

3939
def self.return_value
4040
# If you method provides a return value, you can describe here what it does
41-
'Return the public build number of the app'
41+
'Return the build number of the app'
4242
end
4343

4444
def self.authors

lib/fastlane/plugin/wpmreleasetoolkit/helper/ios/ios_version_helper.rb

Lines changed: 0 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -180,14 +180,6 @@ def self.get_internal_version
180180
get_version_strings()[1]
181181
end
182182

183-
# Returns the current value of the `BUILD_NUMBER` key from the public xcconfig file
184-
#
185-
# @return [String] The current build number according to the public xcconfig file.
186-
#
187-
def self.get_build_number(xcconfig_file)
188-
read_build_number_from_config_file(xcconfig_file)
189-
end
190-
191183
# Prints the current and next release version numbers to stdout, then return the next release version
192184
#
193185
# @return [String] The next release version to use after bumping the currently used public version.

0 commit comments

Comments
 (0)